Fixes #2388 Replace Toasts with Snackbars #5585
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neeldoshii
force-pushed
the
Replace-toasts-with-snackbars-#2388
branch
from
158850c
to
f5f79d2
Compare
neeldoshii
force-pushed
the
Replace-toasts-with-snackbars-#2388
branch
from
c9f4ec6
to
3ba2aa4
Compare
|
Sorry for the delay in reviewing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Purpose/ Description
I have used the methods of Snackbars from ViewUtil and utilized it to convert some toasts to Snackbar.
Note : It doesn't refactor every toast but it covers most of the toasts to snackbar.
Video
Permission Utils Toast (Before)
ca87981c-e06c-4deb-b0a7-e17a0545b06a.mp4
Permission Utils Snackbar (After)
permission_snackbar.webm
Depiction Toast (Before)
depiction.webm
Depiction Snackbar (After)
depiction.mp4
**Recent Search Toast(Before)
recent_search.mp4
**Recent Search Snackbar(After)
recent_search.mp4