Fixes #5564 Add Date & Time in FeedBack Content #5577
Conversation
Made Changes in app/src/main/java/fr/free/nrw/commons/feedback/FeedbackContentCreator.java Added current Date & Time feature in feedback Content
This comment was marked as resolved.
This comment was marked as resolved.
| @@ -28,6 +30,10 @@ public FeedbackContentCreator(Context context, Feedback feedback) { | |||
| public void init() { | |||
| // Localization is not needed here, because this ends up on a page where developers read the feedback, so English is the most convenient. | |||
|
|
|||
| LocalDateTime currentDateTime = LocalDateTime.now(); | |||
There was a problem hiding this comment.
Call requires API level 26 (current min is 21): java.time.LocalDateTime#now
Call requires API level 26 (current min is 21): java.time.format.DateTimeFormatter#ofPattern
Call requires API level 26 (current min is 21): java.time.LocalDateTime#format
This will throw error on API 26. You will need to use desugaring inorder to get this support towards to API 21.
This will increase unnecessary refactoring this can be done with this 2 line of code.
final SimpleDateFormat formatter = new SimpleDateFormat("yyyy-MM-dd HH:mm:ss", Locale.ENGLISH);
String formattedDateTime = formatter.format(new Date());
There was a problem hiding this comment.
@Gupta-Suruchi Would you mind trying that? :-)
| @@ -89,6 +95,10 @@ public void init() { | |||
| } | |||
| stringBuilder.append("~~~~"); | |||
| stringBuilder.append("\n"); | |||
| // adds Current Date & Time when a Feedback is created | |||
| stringBuilder.append("Generated on: " + formattedDateTime); | |||
There was a problem hiding this comment.
Consider replacing this line with this
stringBuilder.append("Generated on: ").append(formattedDateTime);
|
Left review with minor changes. Review by student. |
|
Can I take this @nicolas-raoul, I have the exact idea how to tackle this while I was reviewing the PR. If this PR is stale can I take this? |
|
@neeldoshii Let's wait for 48 hours after my "Would you mind trying that?" comment above, then if there is no response you can build upon this pull request. Thanks both! :-) |
|
@neeldoshii Feel free to build upon this pull request. :-) |
Fixes #5564
What changes did you make and why?
Made Changes in app/src/main/java/fr/free/nrw/commons/feedback/FeedbackContentCreator.java
Added current Date & Time feature in feedback Content as mentioned in issue that, If a user submits multiple feedback with the same version of the Commons app, these cannot be distinguished in the overview.
Note: Please ensure that you have read CONTRIBUTING.md if this is your first pull request.