Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Clicking on edit photo shows default rotation #5575

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

kanahia1
Copy link
Contributor

Description (required)

Fixes #5502

What changes did you make and why?

Tests performed (required)

Tested prodDebug on Samsung S21 FE with API level 33.

Screenshots (for UI changes only)

WhatsApp.Video.2024-02-02.at.13.23.12_d63285c9.mp4

Copy link
Contributor

@shashankiitbhu shashankiitbhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review by student

Unable to Build, Please take a pull from the main and make changes accordingly.

@kanahia1
Copy link
Contributor Author

kanahia1 commented Mar 1, 2024

@shashankiitbhu, I am still facing an error

org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':app:mergeBetaDebugResources'.
	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.lambda$executeIfValid$1(ExecuteActionsTaskExecuter.java:149)
	at org.gradle.internal.Try$Failure.ifSuccessfulOrElse(Try.java:2[82](https://github.com/commons-app/apps-android-commons/actions/runs/8114615843/job/22180660355?pr=5575#step:10:83))
	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeIfValid(ExecuteActionsTaskExecuter.java:147)

@shashankiitbhu
Copy link
Contributor

shashankiitbhu commented Mar 1, 2024

@kanahia1 For this you can just remove the folder for yue-hant.

My review wasn't related to this, I was building the app after removing this, your pull request is failing to build even after removing this folder.

Please try building it after removing this folder and you will see other errors.

Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last step seems problematic:

screen-20240324-193322.mp4

@kanahia1
Copy link
Contributor Author

Oh, Looking into it! Will share PR asap ;)

@nicolas-raoul
Copy link
Member

Did you get a chance to look at this, maybe? :-)

@kanahia1
Copy link
Contributor Author

kanahia1 commented Apr 1, 2024

Fixed the animation issue, but it landed me into another issue. Trying to fix it!

WhatsApp.Video.2024-04-01.at.22.17.05_cc713800.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Clicking on edit photo shows default rotation (Upload Activity)
3 participants