-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #3463 remove usage of assert and replace with appropriate assertThat's #5574
Open
Atheer2104
wants to merge
37
commits into
commons-app:main
Choose a base branch
from
DD2480-group8-VT24:refactor_assert_to_assert_that
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fixes #3463 remove usage of assert and replace with appropriate assertThat's #5574
Atheer2104
wants to merge
37
commits into
commons-app:main
from
DD2480-group8-VT24:refactor_assert_to_assert_that
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #3463
What changes did you make and why?
The changes that were made was to replace the junit assert in the test suite to use hamcrest assertThat instead. Now Most of the test case were applicable have been changed from assert to use assertThat. Note there are still some test cases left that still rely on assert.
Tests performed (required)
Testing was performed, the entire test suite was run and all the of tests that succeeded before the rewrite succeed now also
Tested {build variant, e.g. ProdDebug} on {name of device or emulator} with API level {API level}.
This was tested on on :app:testBetaDebugUnitTest, the API level was 34
Screenshots (for UI changes only)
Need help? See https://support.google.com/android/answer/9075928
Note: Please ensure that you have read CONTRIBUTING.md if this is your first pull request.