Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Enable Jetpack Compose #5520

Open
wants to merge 182 commits into
base: main
Choose a base branch
from

Conversation

AbdhilahiRWabwire
Copy link

@AbdhilahiRWabwire AbdhilahiRWabwire commented Feb 6, 2024

Jetpack Compose

This pull request audits the Gradle Build, Updates Dependencies, Migrates from KAPT to KSP, Enables Jetpack Compose and Enables Dependabot

@nicolas-raoul
Copy link
Member

Is this about an existing bug or enhacement request? If yes would you mind providing the URL? Thanks!

@AbdhilahiRWabwire
Copy link
Author

This is GitHub Dependabot. Dependabot automatically updates dependencies in GitHub Projects. Dependabot is built into GitHub.

interval: "weekly"
time: "03:00"

- package-ecosystem: "maven"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need this? Do we use Maven dependencies?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependabot updates Gradle dependencies and Maven packages in unison. For this to work, both must be declared. In fact, Gradle projects benefit the most from Dependabot. Everyone loves Dependabot.

@nicolas-raoul
Copy link
Member

I think it would be great to have it indeed.
Would you mind trying that bot on your fork, so that we can see whether unit tests still pass after the bot has updated dependencies? There will probably be a lot of updates the first time, so better have the fixes ready. Thanks! :-)

@AbdhilahiRWabwire
Copy link
Author

Understood

dependabot bot and others added 20 commits February 6, 2024 03:46
Bumps androidx.browser:browser from 1.3.0 to 1.7.0.

---
updated-dependencies:
- dependency-name: androidx.browser:browser
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
#2)

Bumps [com.jakewharton.rxbinding2:rxbinding-appcompat-v7](https://github.com/JakeWharton/RxBinding) from 2.1.1 to 2.2.0.
- [Release notes](https://github.com/JakeWharton/RxBinding/releases)
- [Changelog](https://github.com/JakeWharton/RxBinding/blob/master/CHANGELOG.md)
- [Commits](JakeWharton/RxBinding@2.1.1...2.2.0)

---
updated-dependencies:
- dependency-name: com.jakewharton.rxbinding2:rxbinding-appcompat-v7
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [com.github.chrisbanes:PhotoView](https://github.com/Baseflow/PhotoView) from 2.0.0 to 2.3.0.
- [Release notes](https://github.com/Baseflow/PhotoView/releases)
- [Commits](Baseflow/PhotoView@2.0.0...2.3.0)

---
updated-dependencies:
- dependency-name: com.github.chrisbanes:PhotoView
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps commons-io:commons-io from 2.6 to 2.15.1.

---
updated-dependencies:
- dependency-name: commons-io:commons-io
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [com.google.code.gson:gson](https://github.com/google/gson) from 2.8.5 to 2.10.1.
- [Release notes](https://github.com/google/gson/releases)
- [Changelog](https://github.com/google/gson/blob/main/CHANGELOG.md)
- [Commits](google/gson@gson-parent-2.8.5...gson-parent-2.10.1)

---
updated-dependencies:
- dependency-name: com.google.code.gson:gson
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps com.github.triplet.play from 2.7.2 to 3.8.6.

---
updated-dependencies:
- dependency-name: com.github.triplet.play
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
#11)

Bumps [org.junit.jupiter:junit-jupiter-api](https://github.com/junit-team/junit5) from 5.10.0 to 5.10.2.
- [Release notes](https://github.com/junit-team/junit5/releases)
- [Commits](junit-team/junit5@r5.10.0...r5.10.2)

---
updated-dependencies:
- dependency-name: org.junit.jupiter:junit-jupiter-api
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/cache](https://github.com/actions/cache) from 3 to 4.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](actions/cache@v3...v4)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [io.reactivex.rxjava2:rxandroid](https://github.com/ReactiveX/RxAndroid) from 2.1.0 to 2.1.1.
- [Release notes](https://github.com/ReactiveX/RxAndroid/releases)
- [Changelog](https://github.com/ReactiveX/RxAndroid/blob/3.x/CHANGES.md)
- [Commits](ReactiveX/RxAndroid@2.1.0...2.1.1)

---
updated-dependencies:
- dependency-name: io.reactivex.rxjava2:rxandroid
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [org.maplibre.gl:android-plugin-scalebar-v9](https://github.com/maplibre/maplibre-plugins-android) from 1.0.0 to 2.0.2.
- [Release notes](https://github.com/maplibre/maplibre-plugins-android/releases)
- [Changelog](https://github.com/maplibre/maplibre-plugins-android/blob/main/CHANGELOG.md)
- [Commits](maplibre/maplibre-plugins-android@v1.0.0...v2.0.2)

---
updated-dependencies:
- dependency-name: org.maplibre.gl:android-plugin-scalebar-v9
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v3...v4)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [org.junit.jupiter:junit-jupiter-engine](https://github.com/junit-team/junit5) from 5.10.0 to 5.10.2.
- [Release notes](https://github.com/junit-team/junit5/releases)
- [Commits](junit-team/junit5@r5.10.0...r5.10.2)

---
updated-dependencies:
- dependency-name: org.junit.jupiter:junit-jupiter-engine
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/setup-java](https://github.com/actions/setup-java) from 3 to 4.
- [Release notes](https://github.com/actions/setup-java/releases)
- [Commits](actions/setup-java@v3...v4)

---
updated-dependencies:
- dependency-name: actions/setup-java
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3 to 4.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@v3...v4)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [com.facebook.soloader:soloader](https://github.com/facebook/soloader) from 0.10.5 to 0.11.0.
- [Release notes](https://github.com/facebook/soloader/releases)
- [Commits](facebook/SoLoader@v0.10.5...v0.11.0)

---
updated-dependencies:
- dependency-name: com.facebook.soloader:soloader
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@AbdhilahiRWabwire
Copy link
Author

AbdhilahiRWabwire commented Feb 6, 2024

@nicolas-raoul Task Complete: com.jackwharton.rxbinding could not be updated because of conflicts with io.reactivex.rxjava

@AbdhilahiRWabwire
Copy link
Author

@nicolas-raoul AVD fails if JDK is updated but the current version of Android Studio uses JDK 17 and JBR 17

@nicolas-raoul
Copy link
Member

Nice, that's very promising! :-)

Somehow the build fails with this error, any idea why?
app/src/main/java/fr/free/nrw/commons/customselector/helper/OnSwipeTouchListener.kt: (42, 9): 'onFling' overrides nothing

I am looking forward to testing the app with all of these updates. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants