Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced Toasts With Snackbars in AchievementsFragment and Leaderboard #5215

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

shankarpriyank
Copy link
Contributor

Description (required)

Fixes #2388

What changes did you make and why?
Replaced Toasts With Snackbars in AchievementsFragment and Leaderboard

@shankarpriyank
Copy link
Contributor Author

It's a bit weird, the tests which are failing in the CI are passing when I test them locally.

@shankarpriyank
Copy link
Contributor Author

Also, the achievement, leaderboard, and contribution fragments are loading and showing relevant information in the beta flavor, which I guess is not the intended behaviour

@nicolas-raoul
Copy link
Member

I think that our achievements calculation server use the production server directly and has no beta version, it was deemed acceptable since it is read-only.

@shankarpriyank
Copy link
Contributor Author

I think that our achievements calculation server use the production server directly and has no beta version, it was deemed acceptable since it is read-only.

Okay, but we still need to fix the tests..

@shankarpriyank
Copy link
Contributor Author

@nicolas-raoul could use some help here

@rohit9625
Copy link
Contributor

As we have defined Snackbar functions in file Util.java. So, it would help if you used them as Snackbars.
@shankarpriyank

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace toasts with snackbars where appropriate
3 participants