Include author info in the Thanks toast

[sivaraam]

Description (required)

The toast shown when thanking an author during review did not include the author's name in it. It is important to show the same since the thank is explicitly sent to the author.

What changes did you make and why?

Included the author info in the thank related toasts.

Tests performed (required)

OnePlus Nord running Android 12

Screenshots (for UI changes only)

Successful thank toast

Draft status reason

I'm not really sure what to do about the corresponding strings in other languages. I suppose the app would be handling them incorrectly since they only take one parameter. Do let me know your thoughts about the same.

Update: I just checked and it seems to be showing the author name in place of the media file name. So, the meaning of the text seems to change unexpectedly. We could shuffle the params around to fix this like Sending thanks for $filename to $authorname but the sentence does not seem to read well to me.

I could think of another alternative too. Anyways, let me hear other's thoughts before that.

---

Note: Please ensure that you have read CONTRIBUTING.md if this is your first pull request.

[nicolas-raoul]

It is working fine.

Question: Why did you mark this as a draft?

[nicolas-raoul]

Ah, that's probably why:

fr.free.nrw.commons.review.ReviewControllerTest > testSendThanks FAILED
    java.util.MissingFormatArgumentException at ReviewControllerTest.kt:143

fr.free.nrw.commons.review.ReviewControllerTest > testSendThanksCaseNull FAILED
    java.util.MissingFormatArgumentException at ReviewControllerTest.kt:170

[sivaraam]

Question: Why did you mark this as a draft?

I've detailed it in the description. Here it is:

I'm not really sure what to do about the corresponding strings in other languages. I suppose the app would be handling them
incorrectly since they only take one parameter. Do let me know your thoughts about the same.

Update: I just checked and it seems to be showing the author name in place of the media file name. So, the meaning of the text seems to change unexpectedly. We could shuffle the params around to fix this like Sending thanks for $filename to $authorname but the sentence does not seem to read well to me.

I could think of another alternative too. Anyways, let me hear other's thoughts before that.

Do share your thoughts.

[neeldoshii]

@sivaraam

Feedback :
Can we replace toast to snackbar in this?
What if Sending thanks for $filename(bigger filename) to $authorname(bigger author name) if this toast text is greater than two line toast won't support it.

In Android 12, the toast view has been redesigned. Toasts are now limited to two lines of text and show the application icon next to the text.

Android Toast

[sivaraam]

Feedback : Can we replace toast to snackbar in this? What if Sending thanks for $filename(bigger filename) to $authorname(bigger author name) if this toast text is greater than two line toast won't support it.

Sure. Thank you for the suggestion. Let me change this when I get around to it. 🙂