fixes the bug regarding copy to subsequent media when near a wikidata place.

[ayushanand308]

Description (required)

Fixes #5057

What changes did you make and why?
Changed the value of "showNearbyFound"(in the method onNearbyPlaceFound) from true to false that may have been conflicting with the method "onBecameVisible" whenever next/previous button was clicked.

Tests performed (required)

Tested ProdDebug on Xiaomi Redmi 9 with API level 29.

[nicolas-raoul]

I just tested, it indeed solves the issue.
Afterwards I also uploaded a non-Wikidata-linked set of pictures, and strangely "Copy to subsequent media" copied the caption from the previous set of pictures. I wonder whether the same happens in the master branch.

[ayushanand308]

@nicolas-raoul I will surely look into this and see if I can do something about it.

[nicolas-raoul]

So far I have not managed to replicate on the master branch the behavior I just described above.

[ayushanand308]

@nicolas-raoul What should be the next step from my side then?

[nicolas-raoul]

As the problem seems to happen only in this pull request branch, there are chances that it is triggered by the pull request's change.
The next step would be to find out why this is happening (for instance by reproducing it and checking in debug mode), and fixing it.
Thank you!

[ayushanand308]

I just tested, it indeed solves the issue. Afterwards I also uploaded a non-Wikidata-linked set of pictures, and strangely "Copy to subsequent media" copied the caption from the previous set of pictures. I wonder whether the same happens in the master branch.

What I understand from this is that if I have 5 images and first two of them are of a wikidata place then the copy to subsequent media should only copy captions to the images which are of a wikidata place(i.e first 2 images) and not to the last 3 images that are of a non-wikidata place, but the pull request change is making the issue of copying the captions to all the 5 images whether it is of a wikidata place or not , right?

[nicolas-raoul]

What I meant is:

First I uploaded a set of 2 images of the Eiffel Tower. The copy button worked great, and the upload finished successfully.
Then I uploaded a set of 3 images of the Louvre Museum.
When I pressed "copy", the subsequent images got the "Eiffel Tower" caption whereas it should have copied "Louvre Museum" from the first image of the set.

[ayushanand308]

@nicolas-raoul Apologies for responding so late, I was caught up in my semester exams. I have understood the issue and will look into it.
I also wanted to ask if I can submit a GSOC proposal regarding commons project to you for review before final proposal submission for any type of feedback.

[nicolas-raoul]

@ayushanand308 No problem, good luck for the exams! Sure, feel free to submit a proposal, please edit it once your pull request gets merged.

[nicolas-raoul]

Did you get a chance to look into this? :-)