Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove usages of assert #3463

Open
macgills opened this issue Mar 4, 2020 · 5 comments · May be fixed by #5574
Open

Remove usages of assert #3463

macgills opened this issue Mar 4, 2020 · 5 comments · May be fixed by #5574
Assignees
@Atheer2104
Labels
bug good first issue

Comments

@macgills
Copy link
Collaborator

macgills commented Mar 4, 2020 •
edited by nicolas-raoul 

/**
 * Throws an [AssertionError] if the [value] is false
 * and runtime assertions have been enabled on the JVM using the *-ea* JVM option.
 */
@kotlin.internal.InlineOnly
public inline fun assert(value: Boolean) {
    assert(value) { "Assertion failed" }
}

and runtime assertions have been enabled on the JVM using the -ea JVM option.
They have not been enabled and won't be. Replace with appropriate AssertThats.
@u7281898
Copy link

Hi, could I please be assigned to this issue.

@u7281898 u7281898 mentioned this issue Oct 30, 2022
Closed
@nicolas-raoul
Copy link
Member

@u7281898 Any progress on this? 🙂

@RitikaPahwa4444 RitikaPahwa4444 mentioned this issue Jan 30, 2024
Closed
@Atheer2104
Copy link

Hello me and four other people are having 1 week to work on open source issue, this is part of our course assignment. We would like to work on this. Can you add me as an assigne ?

@nicolas-raoul
Copy link
Member

@Atheer2104 It is yours! 🙂

@cyrille-artho
Copy link

I think you can fix this with a one-line shell script:

find . -name '*.kt' | xargs grep -l 'assert *(' | xargs sed -i -e 's/assert *(/AssertThat (/'

Glassar added a commit to DD2480-group8-VT24/apps-android-commons that referenced this issue Feb 27, 2024
@Glassar
fix: project plan for issue commons-app#3463
dfa5167 
 Change it account for us working on multiple issues
@Atheer2104 Atheer2104 linked a pull request Feb 27, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Atheer2104 Atheer2104

Labels
bug good first issue
Projects
None yet
Milestone
No milestone
6 participants
@nicolas-raoul @macgills @domdomegg @cyrille-artho @Atheer2104 @u7281898