Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Copy to subsequent media" does not work if depicts Wikidata place #5057

Open
nicolas-raoul opened this issue Sep 23, 2022 · 17 comments · May be fixed by #5108 or #5163
Open

"Copy to subsequent media" does not work if depicts Wikidata place #5057

nicolas-raoul opened this issue Sep 23, 2022 · 17 comments · May be fixed by #5108 or #5163
Assignees

Comments

@nicolas-raoul
Copy link
Member

nicolas-raoul commented Sep 23, 2022

Steps to reproduce:

  1. Take several pictures near a Wikidata place
  2. Upload both together.
  3. When asked whether the pictures depict the place, say yes.
  4. Write a caption/description
  5. Tap "Copy to subsequent media"
  6. Tap "Next"
  7. Expected: The caption/description from step 4 has not been copied. Problem: The caption/description is from the Wikidata place.

Workaround: Tap "Previous" and tap "Copy to subsequent media" again. This time it works.

@DamienBradleyDSP
Copy link

Hi, I cannot recreate this bug - tried both 4.0 release and master versions.

Select existing place -> upload images -> click yes -> delete name and description that has been copied into fields -> enter name / description -> copy to subsequent media -> upload -> next image contains copied fields.

@nicolas-raoul
Copy link
Member Author

Interesting, there may be special conditions I have not thought of.

@nicolas-raoul
Copy link
Member Author

@junhaow1 Yes thanks! First, please let us know whether you are able to reproduce the issue.

@arinmodi
Copy link
Contributor

Can I work on these issue if @junhaow1 not working ?

@nicolas-raoul
Copy link
Member Author

@arinmodi Feel free to work on it, thanks!

@nicolas-raoul nicolas-raoul assigned arinmodi and unassigned junhaow1 Jan 3, 2023
@arinmodi
Copy link
Contributor

arinmodi commented Jan 4, 2023

@nicolas-raoul, not able to reproduce

@ayushanand308
Copy link

@nicolas-raoul
When I reproduce the issue, I am not getting any bug occurrence. The captions and description is getting copied to the whole batch without having tapped the previous. Am I missing something here?

@ayushanand308
Copy link

ayushanand308 commented Feb 27, 2023

When setting the development environment, I am getting the following errors. Is there any way out?

Screenshot 2023-02-27 164022

@nicolas-raoul
Copy link
Member Author

@ayushanand308 For such errors I recommend searching the web for these error messages.

@nicolas-raoul
Copy link
Member Author

@arinmodi @ayushanand308 I just tried and was able to reproduce the issue the first time. Make sure you are getting the popup at step 3. If not, edit the pictures' EXIF to be at the location of the Eiffel Tower, then select both and share to the Commons app.

@ayushanand308
Copy link

@nicolas-raoul I followed what you said and was able to successfully reproduce the issue.

@nicolas-raoul
Copy link
Member Author

@ayushanand308 Great! Do you want to be assigned to this issue? 🙂

@ayushanand308
Copy link

@nicolas-raoul Yes!

@nicolas-raoul
Copy link
Member Author

@ayushanand308 It is yours! Please let us know about your progress every few days. Thanks! :-)

@ayushanand308
Copy link

@nicolas-raoul
Copy link
Member Author

Yes exactly 🙂

ayushanand308 added a commit to ayushanand308/apps-android-commons that referenced this issue Mar 4, 2023
@ayushanand308
Copy link

@nicolas-raoul I have made a PR. Can you kindly review it. :-).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment