Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add es, eu & fa #88

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add es, eu & fa #88

wants to merge 1 commit into from

Conversation

Gregoor
Copy link
Contributor

@Gregoor Gregoor commented Feb 20, 2019

No description provided.

@kdavis-mozilla
Copy link
Contributor

Why are we adding languages when the clips file was frozen several weeks ago?

@Gregoor
Copy link
Contributor Author

Gregoor commented Feb 20, 2019

Oh I can get you a new clips file, it's part of the new export. But part of the export is also running CorporaCreator, which currently causes the export to fail :/

@kdavis-mozilla
Copy link
Contributor

Getting a new clips is not the problem.

I'm more commenting on the fact that we should have, and as far as I understood we did, freeze the release clips.tsv weeks ago to focus on cleaning it up instead of adding new languages.

@Gregoor
Copy link
Contributor Author

Gregoor commented Feb 20, 2019

Oh, I didn't think those were contradictory goals, as cleaning up is an ongoing effort.

@kdavis-mozilla
Copy link
Contributor

My point is that we have to, and my understanding is that we did several weeks ago, freeze clips.tsv

Adding newer and newer clips.tsv files closer and closer to the deadline will only ensure that the data set is not sufficiently vetted.

@Gregoor
Copy link
Contributor Author

Gregoor commented Feb 20, 2019

Okay, I'll reach out to the rest of the team to make sure we're aligned on this.

@kdavis-mozilla
Copy link
Contributor

Did you get any answers from the rest of the team?

@Gregoor
Copy link
Contributor Author

Gregoor commented Feb 21, 2019

Not really, I posted it in our internal Slack channel (so that you would see it too). I just went with the assumption that your memory is better than mine and changed the bundling to only get clips from the same time range as the clips.tsv dump.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants