Will invalidate sentences with question mark in the middle #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding validation for sentences with question mark before lower case character.
This PR extends comments mentioned in #126
Current code in this PR does not do any special validations for Spanish as it assumes that the regular question mark "?" before lower case character is still invalid for Spanish and valid cases would be use of upside down question mark "¿" or regular question mark "?" before upper case character.
Also as this code marks sentences invalid and does not drop them completely they can still be picked up from the invalidated set if needed.
Happy to adjust the code with more specific checks for Spanish if someone guides me on valid and invalid examples for Spanish