Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bound on ansi-terminal #7420

Merged
merged 1 commit into from
May 16, 2024
Merged

Conversation

andreasabel
Copy link
Contributor

Fixes #7392

@juhp
Copy link
Contributor

juhp commented May 14, 2024

Hmm this seems to not work or be incomplete?

ansi-terminal-1.1.1 (changelog) (Mike Pilgrem public@pilgrem.com @mpilgrem) is out of bounds for:

@mpilgrem
Copy link
Member

mpilgrem commented May 14, 2024

OK, those are new since #7306. As fourmolu and ormolu principally provide executables (rather than a library), perhaps ansi-terminal could be included and those excluded until their bounds are relaxed?

@juhp
Copy link
Contributor

juhp commented May 14, 2024

OK, those are new since #7306. As fourmolu and ormolu principally provide executables (rather than a library), perhaps ansi-terminal could be included and those excluded until their bounds are relaxed?

Probably not - I am relunctant to do that as we approach lts-23

@mpilgrem
Copy link
Member

mpilgrem commented May 14, 2024

Can you elaborate? If LTS 23 is on the horizon, that seems to me to be another reason to ensure ansi-terminal-1.1.x is reintroduced into the nightly snapshots.

EDIT2: My frustration is that ansi-terminal-1.1 was released over three months ago, and it was disappointing to annouce its inclusion in nightly-2024-04-10 only to have that reversed because of the concurrent-output-1.10.20 (>=0.6.2 && < 1.1.0) problem when the minor bump ansi-terminal-1.1.1 was released.

EDIT: In the meantime, I'll make some pull requests ...

@juhp
Copy link
Contributor

juhp commented May 15, 2024

Sure I would like to see 1.1 in Nightly and Stackage 23 too, but to me ormolu and fourmolu are important tools in the Haskell ecosystem so it seems unfortunate to me for them not to available in Stackage as far as possible.

Anyway hopefully their revisions and/or new releases could be made soon promptly and we can have both.

@juhp juhp merged commit a21d2cc into commercialhaskell:master May 16, 2024
1 check failed
@andreasabel andreasabel deleted the patch-2 branch May 16, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ansi-terminal 1.1.1
3 participants