avoid ImageSharpen node bug on macOS #3392
Open
+6
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why not just check if the torch device is MPS? |
bigcat88
force-pushed
the
fix-macOS-ImageSharpen-3383
branch
from
f6e88e6
to
e1e7e15
Compare
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
bigcat88
force-pushed
the
fix-macOS-ImageSharpen-3383
branch
from
e1e7e15
to
1471835
Compare
|
I can’t imagine someone running Comfy on a CPU on macOS(PyTorch 2.3 dropped x86 macOS support as I know) Anyway the question is good, I changed code to check for MPS device. |
|
@comfyanonymous sorry to bother you, but are you fine with this PR or not? |
shawnington
reviewed
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert change only for macOS
Resolves: #3383