feat: ✨ add support for "*" output types #3329
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effectively skipping type checking. There are already trick to do the same for inputs using `kwargs`. There are probably implications I haven't fully thought about and I didn't test it extensively myself
melMass
added a commit
to melMass/comfy_mtb
that referenced
this pull request
Apr 25, 2024
This requires this PR to be merged: comfyanonymous/ComfyUI#3329 There is a trick to make it work without that PR but it feels very hacky, the code for it is kept for reference but unused
|
@comfyanonymous I've been running this branch for 2 weeks and it seems to work just fine (with >70 third party extensions). Do you see any issues in allowing that? I can run further tests if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
effectively skipping type checking.
There are already trick to do the same for inputs using
kwargs.There are probably implications I haven't fully thought about and I didn't test it extensively myself