PR: CuPy Based GPU Backend #625
Draft
+4,351
−2,851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, coordinates, temperature, difference, biochemistry, colorimetry and algebra. Currently parts of the last two modules do not work.
…se functions, continous/signal-Multisignal, rgb/derivation, temperature CCT_to_xy, XYZto_sd_Meng2015, notation/munsell and primitive_grid/cube
…y instead of numpy, redefined the as_float for numpy to avoid the zero division error, currently all tests work on numpy and some of them do not work on cupy as shared in the document
…several functions more compact
|
Thanks @OmarWagih1! Would it be possible to rebase this on develop so that there are only the commits pertaining to the GPU backend please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The state of the repository right now is that most tests pass (only about 30 tests fail) with a default backend of CuPy.
All failed tests are mentioned in this document with the reason of their failure
https://docs.google.com/document/d/1Ag7Yh6Ovi1zKwZSv2p-ckwC6gTuZrzb5CUUt3f7iShc/edit
Some tests fail because the randomization between CuPy and NumPy is different, so while the code works correctly the tests do not pass. Some functions are not implemented with CuPy backend and others are not compatible with CuPy.
The code needs working on to be better looking as some Numpy/Cupy switches were crudely done.