Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no postError field existance on non-fields #1381

Open
wants to merge 1 commit into
base: dev/php8
Choose a base branch
from

Conversation

peterjanssens
Copy link
Contributor

when debug_output enabled we get postErrors on non-errors.

in this case going from a set to the batch editor the BaseModel is loaded for instance with pm_id array(2) { [21]=> int(28) ["all"]=> int(14) }

The condition here is tested for vs_field 21 that is not a field. It is probably 'correct' that is not a field, but not important feedback either ?

I'm guessing here that the routine can be exited too, so kept the return (false) as-is

@collectiveaccess
Copy link
Owner

Hmm, there's more to this I think. I'll investigate.

@peterjanssens
Copy link
Contributor Author

peterjanssens commented Dec 21, 2022

14 is the identifier for the (standard) editor ui, not sure yet where the 21 points to
you only get the Notifications managed when __CA_ENABLE_DEBUG_OUTPUT__ is enabled, so usually 'muted'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants