Fixed has_release? when called in multiple windows #168
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
has_release
does not work with long running workflows. Once has_release has been hit once, it will never change its value for the lifetime of a workflow.Example
Original
Modification
The desired outcome with releasing this modification is that all future loops will call the new code, but previous tasks will execute the original version. Prior to this PR, the original code will always be executed.
With this change, here are the possible scenarios:
has_release
seen for the first time when not replaying --- mark releasehas_release
seen for the first time while replaying --- set tofalse
locallyhas_release
seen for first time while replaying and then again while not replaying -- mark releasehas_release
seen for first time when not replaying and then again while not replaying -- use previous value / don't mark release