Converted WorkflowExecutionAlreadyStartedFailure handling to use RPC status #144
+120
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antstorm
suggested changes
Feb 25, 2022
There was a problem hiding this comment.
Thank you for the PR, @cvanderschuere ! Few small comments, but overall looks great 👍
antstorm
reviewed
Mar 4, 2022
cvanderschuere
force-pushed
the
found/alreadyStartedError
branch
from
5f0d69c
to
da0f343
Compare
|
@antstorm this should be ready for another review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ran into a condition where the error message changed slightly and we were unable to extract the Run ID. This changes moves to start using the RPC error in a similar way to the Go SDK.