Timer operations testing sync #106
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeRauk
commented
Oct 1, 2021
| @@ -95,6 +107,8 @@ def start_locally(workflow, schedule, *input, **args) | |||
| execution, workflow_id, run_id, workflow.disabled_releases, metadata | |||
| ) | |||
|
|
|||
| Temporal::ThreadLocalContext.set(context) | |||
There was a problem hiding this comment.
Two tests are failing and I have a hunch it's related to this line (110).
./spec/unit/lib/temporal/testing/temporal_override_spec.rb:106 # Temporal::Testing::TemporalOverride when testing mode is local Workflow.execute_locally restores original context after finishing successfully/spec/unit/lib/temporal/testing/temporal_override_spec.rb:117 # Temporal::Testing::TemporalOverride when testing mode is local Workflow.execute_locally restores original context after failing
They don't fail when run by themselves, just when the whole test suite is run. Not sure what the best way to fix is.
These tests aren't in the Cadence library.
antstorm
approved these changes
Oct 16, 2021
calum-stripe
pushed a commit
to calum-stripe/temporal-ruby
that referenced
this pull request
Nov 10, 2022
…oner/downstream Downstream latest temporal-ruby changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
coinbase/cadence-ruby#57