(POC) Pin cursors to connections #70
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestonvasquez
commented
Apr 12, 2024
| @@ -116,3 +121,107 @@ func TestRoundTripProcessError(t *testing.T) { | |||
|
|
|||
| assert.Equal(t, description.ServerKind(description.Unknown), m.Description().Servers[0].Kind, "Failed to update the server Kind to Unknown") | |||
| } | |||
|
|
|||
| func TestMongo_RoundTrip_Cursor(t *testing.T) { | |||
| const uri = "mongodb://127.0.0.1:8001/?loadBalanced=true" | |||
There was a problem hiding this comment.
This will have to be changed to reflect local and CI requirements for MongoBetween development
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of MongoBetween uses a cursor caching solution with N >= 1 Mongos (LB7), so cursors being pinned to servers is acceptable. However, when load-balancing at the TCP layer it is not possible to target the same Mongos behind a load balancer when pooling connections (which is done under the hood in the Go Driver). This PR proposes pinning cursors and transactions to connections to account for this.