Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set minimum C++ standard needed to compile Coin #518

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ric-bianchi
Copy link

The compilation of the Coin 'master' fails out of the box because the minimum C++ standard is not specified in the CMake configuration, and the old standard is picked by CMake by default (at least on macOS).

This PR adds the minimum C++ standard to CMakeLists.txt.

That fixes the out-of-the-box build of Coin.

Tested on macOS 13.5.1 + Xcode 15.1

@VolkerEnderlein
Copy link
Collaborator

Thanks for the PR. I just checked with the macos-13 github runner image (macos-latest still defaults to macos-12). It looks like the dependency to boost 1.84 causes coin not to compile with C++ 03 anymore, as boost 1.82 declared support for C++03 deprecated.

@VolkerEnderlein
Copy link
Collaborator

I am still unsure about merging the PR, as it is only a 3rd party dependency that requires this. So I started a poll on the Coin3D discussions tab https://github.com/orgs/coin3d/discussions/520 . Feel free to vote. Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants