Fix uri parse error in the Windows system.

[Caij]

Please run ./test.sh before submitting to ensure your pull request passes the automated checks.

[Caij]

Windows local path parse error. D:\test\relative\image.jpg

class Factory : Fetcher.Factory<Uri> {
        override fun create(
            data: Uri,
            options: Options,
            imageLoader: ImageLoader,
        ): Fetcher? {
            if (!isFileUri(data)) return null
            return FileUriFetcher(data, options)
        }
    }

internal fun isFileUri(uri: Uri): Boolean {
    return (uri.scheme == null || uri.scheme == SCHEME_FILE) &&
        uri.path != null &&
        !isAssetUri(uri)
}

Here the uri.path is empty, so the FileUriFetcher factory can't be found.

[colinrtwhite]

Is it correct that scheme is null? Should it be D?

[Caij]

Is it correct that scheme is null? Should it be D?

I think D is the volume information, it should be part of the path.

[colinrtwhite]

Thanks for taking a stab at this - unfortunately looks like the tests are failing with a StackOverflowError. You can run the tests locally using ./test.sh.

[Caij]

Thanks for taking a stab at this - unfortunately looks like the tests are failing with a StackOverflowError. You can run the tests locally using ./test.sh.

There was an error and I fixed it, and it has been submitted.

[colinrtwhite]

Sorry for the delay on merging this. After thinking about this I think we might want to handle Windows file paths a different way.

Changing the Uri class to handle backslash file paths technically violates the URI spec. Instead the spec recommends converting the file paths to use forward slashes, which we could handle with a custom Mapper for Windows targets. Though I'm not sure how we would get the correct Windows path back afterwards to pass to Okio.

[Caij]

Sorry for the delay on merging this. After thinking about this I think we might want to handle Windows file paths a different way.

Changing the Uri class to handle backslash file paths technically violates the URI spec. Instead the spec recommends converting the file paths to use forward slashes, which we could handle with a custom Mapper for Windows targets. Though I'm not sure how we would get the correct Windows path back afterwards to pass to Okio.

Yes, I don't think my approach is very elegant, but I can't think of a better way to handle this, looking forward to your solutions.
Our current solution is set custom fetch factory for Windows targets.