Use rememberCoroutineScope in AsyncImagePainter. #2220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlykotom
reviewed
Apr 29, 2024
| // Create a new scope to observe state and execute requests while we're remembered. | ||
| val scope = CoroutineScope(SupervisorJob() + Dispatchers.Main.immediate) | ||
| rememberScope = scope | ||
| if (rememberJob != null) return |
There was a problem hiding this comment.
Would it be safer to use if(rememberJob?.isActive == true) return ?
Maybe the coroutine won't ever be cancelled without calling clear() though?
There was a problem hiding this comment.
Ah yep that's probably better 👍. Theoretically Compose could cancel the parent scope at any time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2181.