添加腾讯jdk #131
Open
添加腾讯jdk #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 10, 2023 17:13
sinkcup
requested changes
Feb 9, 2024
| @@ -30,6 +30,7 @@ php.tar.xz | 8.1.0 | https://www.php.net/distributions/php-8.1.0.tar.xz | a1317e | |||
| rancherd-amd64.tar.gz | v2.5.9 | https://github.com/rancher/rancher/releases/download/v2.5.9/rancherd-amd64.tar.gz | 61222a6d57ecdd109a0063d6422390c865ab8d11b63b42e43bac09e0a999562e | |||
| shellcheck-linux-x86-64.tar.xz | v0.7.2 | https://github.com/koalaman/shellcheck/releases/download/v0.7.2/shellcheck-v0.7.2.linux.x86_64.tar.xz | 70423609f27b504d6c0c47e340f33652aea975e45f312324f2dbf91c95a3b188 | |||
| shfmt-linux-amd64 | v3.3.1 | https://github.com/mvdan/sh/releases/download/v3.3.1/shfmt_v3.3.1_linux_amd64 | 0f73bf27219571bca7c5ef7d740d6ae72227e3995ffd88c7cb2b5712751538e2 | |||
| TencentKona-17.0.7.b1-jdk_linux-x86_64 | 17.0.7.b1 |https://github.com/Tencent/TencentKona-17/releases/download/TencentKona-17.0.7/TencentKona-17.0.7.b1-jdk_linux-x86_64.tar.gz|2D565E62B2715EDA2DD7D79379E4CD7F3F909C235579580C8427487974C36273 | |||
There was a problem hiding this comment.
很久没人审？我来看看，有些小问题：
- 从 fork main 到 upstream main 不合适，应在 fork 库中拉取临时分支，main 保持持续同步
- 文件名缺少后缀
- 小版本号不应出现在文件名中，包仓库的管理逻辑是：文件名不变，而版本号持续变化。
Suggested change
| TencentKona-17.0.7.b1-jdk_linux-x86_64 | 17.0.7.b1 |https://github.com/Tencent/TencentKona-17/releases/download/TencentKona-17.0.7/TencentKona-17.0.7.b1-jdk_linux-x86_64.tar.gz|2D565E62B2715EDA2DD7D79379E4CD7F3F909C235579580C8427487974C36273 | |
| TencentKona-17-jdk_linux-x86_64.tar.gz | 17.0.7.b1 | https://github.com/Tencent/TencentKona-17/releases/download/TencentKona-17.0.7/TencentKona-17.0.7.b1-jdk_linux-x86_64.tar.gz| 2D565E62B2715EDA2DD7D79379E4CD7F3F909C235579580C8427487974C36273 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
添加腾讯jdk TencentKona支持