Don't update content if it is undefined #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the current state, if content prop is undefined, the editor would reset his content at every update. Checking if content prop is undefined before updating fixes this behavior. If one needs to reset the editor he can pass an empty string to the content prop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Thanks for the great plugin !
The problem
In the current state, if content prop is undefined, the editor would reset his content on every update.
The solution
Check if content prop is defined before updating editor data.
Why do we want that ?
(I don't want the editor to be fully controlled because it will cause a lot of useless renders and a lot of calls to getData(), I prefer to update my content on
blureventNotes
If someone needs to reset the editor he can pass an empty string to the content prop.