fix: update tests for useClipboard to minimize risks of flakes #13250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parkreiner
requested review from
a team and
aslilac
and removed request for
a team
aslilac
approved these changes
May 14, 2024
site/src/hooks/useClipboard.test.tsx
Outdated
Comment on lines
160
to
168
| console.error = (errorValue, ...rest) => { | ||
| const canIgnore = | ||
| errorValue instanceof Error && | ||
| errorValue.message === COPY_FAILED_MESSAGE; | ||
|
|
||
| if (!canIgnore) { | ||
| originalConsoleError(errorValue, ...rest); | ||
| } | ||
| }; |
There was a problem hiding this comment.
is there a reason we can't use spyOn or something? feels like jest could be helping with this
There was a problem hiding this comment.
Oh, yeah, good call – just wasn't thinking straight when I wrote that. Just fixed things
|
@aslilac Do you think there's anything else I could do to make the code more scrutable? I wish the tests were a bit more straightforward, but I don't know how much of that is the nature of what's being tested, vs my own abilities to write easy-to-follow code |
|
I think it's a pretty hard spot to scratch, and it might not be worth pouring even more time into as long as this fixes the flakes. 😅 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13240
Changes made
describe.eachto improve test isolation between HTTPS and HTTP-only test cases