DRAFT: Add clang-tidy testing #61
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coldav
force-pushed
the
colin/add_clang_tidy_pr_testing
branch
from
f0a3881
to
c0f9916
Compare
coldav
force-pushed
the
colin/add_clang_tidy_pr_testing
branch
16 times, most recently
from
8f27aa9
to
d960543
Compare
MaryaSharf
approved these changes
Jul 18, 2023
coldav
force-pushed
the
colin/add_clang_tidy_pr_testing
branch
from
d960543
to
d496e08
Compare
Added an extra workflow job to do clang-tidy testing. This does an initial build before calculating dependencies and then calling clang-tidy. Switched to using clang-tidy-12 (in the CMakelists.txt and the job)
coldav
force-pushed
the
colin/add_clang_tidy_pr_testing
branch
from
d496e08
to
17f6674
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add clang-tidy testing
Reason for change
clang-tidy testing does not yet exist on github.
Description of change
Added a job in the PR testing workflow to build the minimum target, compute dependencies and run clang-tidy on the result,
based on what files have changed.
Checklist