Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Cute tests #57

Merged

Conversation

AD2605
Copy link
Collaborator

@AD2605 AD2605 commented Apr 30, 2024

Enables Cute Tests via SYCL Path

mehdi-goli and others added 10 commits April 4, 2024 18:05
…tware#16)

* Updating README-sycl.md to capture the 3.5 modifications

* Update README-sycl.md

Co-authored-by: aacostadiaz <alejandro.acosta@codeplay.com>

* Remove the sgemm_nt_1_sycl PoC (codeplaysoftware#15)

* Remove sgemm_nt_1 PoC

* Fix build issues

* Fix code style format

* Remove ENABLE_NVPTX flag

* Update include/cute/util/debug.hpp

Co-authored-by: Mehdi Goli <mehdi.goli@codeplay.com>

* Cosmetic

---------

Co-authored-by: Mehdi Goli <mehdi.goli@codeplay.com>

* Applying the comments

---------

Co-authored-by: aacostadiaz <alejandro.acosta@codeplay.com>
@AD2605 AD2605 marked this pull request as ready for review May 1, 2024 09:55
Co-authored-by: Mehdi Goli <mehdi.goli@codeplay.com>
Copy link
Collaborator

@aacostadiaz aacostadiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

aacostadiaz and others added 2 commits May 13, 2024 11:44
Co-authored-by: Mehdi Goli <mehdi.goli@codeplay.com>
Copy link
Collaborator

@muhammad-tanvir-1211 muhammad-tanvir-1211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit picks, but looks good otherwise. Thanks.

test/unit/CMakeLists.txt Outdated Show resolved Hide resolved
test/unit/cute/CMakeLists.txt Outdated Show resolved Hide resolved
Copy link
Collaborator

@mehdi-goli mehdi-goli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aacostadiaz aacostadiaz merged commit 9d12ff6 into codeplaysoftware:sycl-develop May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants