Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix the testcase error on MariaDB. #7989

Merged
merged 2 commits into from
Oct 1, 2023
Merged

test: fix the testcase error on MariaDB. #7989

merged 2 commits into from
Oct 1, 2023

Conversation

ping-yee
Copy link
Contributor

Description
See the first error of #7929

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added bug Verified issues on the current code behavior or pull requests that will fix them testing Pull requests that changes tests only and removed bug Verified issues on the current code behavior or pull requests that will fix them labels Sep 28, 2023
@kenjis kenjis changed the title fix: fix the testcase error on mariaDB. test: fix the testcase error on mariaDB. Sep 28, 2023
@kenjis kenjis changed the title test: fix the testcase error on mariaDB. test: fix the testcase error on MariaDB. Sep 28, 2023
@kenjis kenjis merged commit 528200f into codeigniter4:develop Oct 1, 2023
59 checks passed
@kenjis
Copy link
Member

kenjis commented Oct 1, 2023

@ping-yee Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neznaika0 neznaika0 neznaika0 left review comments

@kenjis kenjis kenjis approved these changes

@TimexPeachtree TimexPeachtree TimexPeachtree approved these changes

Assignees
No one assigned
Labels
testing Pull requests that changes tests only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ping-yee @kenjis @neznaika0 @TimexPeachtree