Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating vars and secrets joey style with help #362

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

JMStudiosJoe
Copy link
Contributor

📜 Description

  • Describe the general shape of this PR (new feature? refactor? bug fix? one-line change?)
  • Describe what changes are being made
  • Describe why these changes are being made
  • List the use cases and edge cases relevant to this PR
  • Describe how errors will be handled. How will we know if this code breaks in production
  • Describe any external libraries/dependencies added or removed in this PR
  • Describe any security risks are there regarding this change
  • Describe how you tested these changes
  • Link to relevant external documentation

📋 Mandatory Checklist

  • Example of a checked item (please remove when creating your Pull Request)

  • Linked to the Github Issues being addressed using the right sidebar ➡️

  • Have you discussed these changes with the project leader(s)?

  • Do all variable and function names communicate what they do?

  • Were all the changes commented and / or documented?

  • Is the PR the right size? (If the PR is too large to review, it might be good to break it up into multiple PRs.)

  • Does all work in progress, temporary, or debugger code have a TODO comment with links to Github issues?

  • If you changed the user interface, did you add before and after screenshots to below?


🖼️ Screenshots and Screen Recordings

Before

After


📘 Glossary

  • PR = Pull Request

@JMStudiosJoe JMStudiosJoe self-assigned this Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants