Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed many sourceURL errors. #104

Merged
merged 2 commits into from Jun 16, 2020
Merged

Fixed many sourceURL errors. #104

merged 2 commits into from Jun 16, 2020

Conversation

kgudger
Copy link
Collaborator

@kgudger kgudger commented Jun 13, 2020

Fixed most of the sourceURL errors.
Addresses #103

@ychoy ychoy self-requested a review June 16, 2020 17:16
Copy link
Collaborator

@ychoy ychoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating these links!

For the public art data scraped from the City of San Jose, the new URLs are good to go.

Please make changes so the PowWowSanJose.com murals do not point to the City of San Jose's website. They should remain the same, pointing to the website PowWowSanJose.com.

@@ -2665,7 +2665,7 @@
"country": "United States",
"postalCode": "95113",
"state": "CA",
"sourceURL": "https://www.powwowsanjose.com/"
"sourceURL": "https://www.sanjoseca.gov/home/showdocument?id=32425"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert these changes. PowWowSanJose.com murals and public art data are not the same as the City of San Jose public art data. These should still be pointing to PowWowSanJose.com

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only powwowsanjose links that got changed are dead links, so I'm a little confused. Are you suggesting that all dead powwowsanjose links should just be changed to www.powwowsanjose.com ? Or just leave them out (change to blank)? Thanks.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These links should not be pointing to the City of San Jose website. That's not where I got my data from. Also the City of San Jose links to public art that is not the same as the murals that are part of the Pow Wow San Jose festival.

It looks like all the mural location information is now being posted to https://www.powwowsanjose.com/mural-locations

@@ -778,7 +778,7 @@
"country": "United States",
"postalCode": "95112",
"state": "CA",
"sourceURL": "https://www.powwowsanjose.com/"
"sourceURL": "https://www.sanjoseca.gov/home/showdocument?id=32399"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -2576,7 +2576,7 @@
"country": "United States",
"postalCode": "95113",
"state": "CA",
"sourceURL": "https://www.powwowsanjose.com/"
"sourceURL": "https://www.sanjoseca.gov/home/showdocument?id=32425"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I to understand that all dead powwowsanjose links should be changed to:
https://www.powwowsanjose.com/mural-locations
If so I can do that.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do, thank you!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, that should be done in my latest push.

@ychoy ychoy merged commit 27cf456 into master Jun 16, 2020
@darpham darpham deleted the kg2-branch branch December 6, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants