Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expo SDK 49 #437

Draft
wants to merge 20 commits into
base: master
Choose a base branch
from
Draft

Expo SDK 49 #437

wants to merge 20 commits into from

Conversation

TylerOrtiz
Copy link

@TylerOrtiz TylerOrtiz commented Mar 14, 2024

Expo upgraded to SDK 49

  • Node.js version 16->18
  • Replace expo-permissions with modules (camera, location, etc)
  • Removed local expo cli
  • patched @react-native-async-storage/async-storage in react-native

Extra stuff:

Comment on lines +32 to +34
// "googleSignIn": {
// "reservedClientId": "com.googleusercontent.apps.439621369113-n8qpls93d89p46dg8rlbkt09k3dnk44s"
// }
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Still needs addressing

Comment on lines +50 to +53
// "googleSignIn": {
// "apiKey": "AIzaSyCOrCzO_pJ3_OVw3ScpwP2Fl6-h4wJ8IOA",
// "certificateHash": "DB62BE57BA941E929F0FBD9FA394EA18D25A6C35"
// },
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Still needs addressing

@nfloersch
Copy link

In testing so far a few comments.

  1. The draft PR seems to work correctly on Android with no errors! Awesome

  2. The draft PR throws errors / crashes on iOS in the Town Info and Trash (Collect Trash) screens. Otherwise it seems to be working fairly well

  3. The version of the codebase that is "main" here is slightly out of date. I'm trying to figure out where the latest built version is... so we may need to make a few more tweaks based on that. Sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants