Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EXPERIMENTAL] use vite #187

Draft
wants to merge 28 commits into
base: m3-main
Choose a base branch
from
Draft

[EXPERIMENTAL] use vite #187

wants to merge 28 commits into from

Conversation

KyleMit
Copy link
Member

@KyleMit KyleMit commented Jan 22, 2023

Experimental refactor to use vite as build system - not a high priority to merge. Might fizzle out

  • Converted to use vite, but haven't fully tested yet.
  • Restrcutured project to use more conventional folder directories (src, public, dist, docs).
    • Allows you to npm install and run the project straight from root.

Todo

  • Convert all script tags into modules (otherwise vite won't do anything)
  • Update docs with new folder directory / structure.
  • Update scripts

@jakedurell
Copy link
Collaborator

@KyleMit - Tried to run "npm run dev" from root and public. Public loads the extensions, but it can't access any of the files needed to run the popup or other extensions.

@KyleMit
Copy link
Member Author

KyleMit commented Jan 22, 2023

@jakedurell - I need to update docs too with this before merging, since I shifted a whole bunch of stuff around. But essentially, npm run dev doesn't really do much for this app. Because after building (whether dev or production), you still have to manually load the unpacked app into extensions, so there's no real "dev server" or auto start. So we'll always just do a regular build. In this PR, that build will go to the dist directory and the extension should be loaded from there

@KyleMit KyleMit changed the title Kylemit/use vite [EXPERIMENTAL] use vite Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants