Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hide direct file on homepage #4520

Merged
merged 3 commits into from May 7, 2024
Merged

hide direct file on homepage #4520

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a3bfd97
hide direct file on homepage
tahsinaislam Apr 26, 2024
4800b6a
hide direct file on homepage
tahsinaislam Apr 26, 2024
e8529c1
Add test
tahsinaislam Apr 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
128 changes: 79 additions & 49 deletions app/views/shared/_service_comparison.html.erb
View file
Open in desktop
Expand Up @@ -45,19 +45,21 @@
<%= link_to t("views.shared.service_comparison.services.diy.cta"), Diy::FileYourselfController.to_path_helper, class: "button", "data-track-click": "service-comparison-diy" %>
</div>
</div>
<div class="service direct-file">
<div>
<h2 class="service__service-name">
<%= t("views.shared.service_comparison.services.direct_file.service_name") %>
</h2>
</div>
<div class="service__description">
<%= t("views.shared.service_comparison.services.direct_file.service_description") %>
</div>
<div class="service__cta">
<%= link_to t("views.shared.service_comparison.services.direct_file.cta"), "https://directfile.irs.gov/state" ,class: "button", "data-track-click": "service-comparison-direct-file"%>
<% if app_time.before?(Rails.configuration.state_file_end_of_in_progress_intakes) %>
<div class="service direct-file">
<div>
<h2 class="service__service-name">
<%= t("views.shared.service_comparison.services.direct_file.service_name") %>
</h2>
</div>
<div class="service__description">
<%= t("views.shared.service_comparison.services.direct_file.service_description") %>
</div>
<div class="service__cta">
<%= link_to t("views.shared.service_comparison.services.direct_file.cta"), "https://directfile.irs.gov/state" ,class: "button", "data-track-click": "service-comparison-direct-file"%>
</div>
</div>
</div>
<% end %>
</div>
</div>
<div class="service-set service-set--mobile-only mobile-sticky-header">
Expand All @@ -70,9 +72,11 @@
<div class="service diy">
<strong><%= t("views.shared.service_comparison.services.diy.service_name") %></strong>
</div>
<div class="service direct-file">
<strong><%= t("views.shared.service_comparison.services.direct_file.service_name") %></strong>
</div>
<% if app_time.before?(Rails.configuration.state_file_end_of_in_progress_intakes) %>
<div class="service direct-file">
<strong><%= t("views.shared.service_comparison.services.direct_file.service_name") %></strong>
</div>
<% end %>
</div>
</div>

Expand All @@ -90,9 +94,11 @@
<div class="service diy">
<%= t("views.shared.service_comparison.income_limit.diy") %>
</div>
<div class="service direct-file">
<%= t("views.shared.service_comparison.income_limit.direct_file") %>
</div>
<% if app_time.before?(Rails.configuration.state_file_end_of_in_progress_intakes) %>
<div class="service direct-file">
<%= t("views.shared.service_comparison.income_limit.direct_file") %>
</div>
<% end %>
</div>
</div>
<div class="service-set service-set--hr">
Expand All @@ -108,9 +114,11 @@
<div class="service diy">
<%= MultiTenantService.new(:gyr).current_tax_year %>
</div>
<div class="service direct-file">
<%= MultiTenantService.new(:gyr).current_tax_year %>
</div>
<% if app_time.before?(Rails.configuration.state_file_end_of_in_progress_intakes) %>
<div class="service direct-file">
<%= MultiTenantService.new(:gyr).current_tax_year %>
</div>
<% end %>
</div>
</div>
<div class="service-set service-set--hr">
Expand All @@ -129,9 +137,11 @@
<div class="service diy">
<%= t("views.shared.service_comparison.time_to_file.diy") %>
</div>
<div class="service direct-file">
<%= t("views.shared.service_comparison.time_to_file.diy") %>
</div>
<% if app_time.before?(Rails.configuration.state_file_end_of_in_progress_intakes) %>
<div class="service direct-file">
<%= t("views.shared.service_comparison.time_to_file.diy") %>
</div>
<% end %>
</div>
</div>
<div class="service-set">
Expand All @@ -143,7 +153,9 @@
<div class="service-set__services service-set--mobile-excluded">
<div class="service full-service"></div>
<div class="service diy"></div>
<div class="service direct-file"></div>
<% if app_time.before?(Rails.configuration.state_file_end_of_in_progress_intakes) %>
<div class="service direct-file"></div>
<% end %>
</div>
</div>
<div class="service-set">
Expand All @@ -159,9 +171,11 @@
<div class="service diy">
<%= t("views.shared.service_comparison.id_documents.diy") %>
</div>
<div class="service direct-file">
<%= t("views.shared.service_comparison.id_documents.diy") %>
</div>
<% if app_time.before?(Rails.configuration.state_file_end_of_in_progress_intakes) %>
<div class="service direct-file">
<%= t("views.shared.service_comparison.id_documents.diy") %>
</div>
<% end %>
</div>
</div>
<div class="service-set service-set--hr">
Expand All @@ -172,9 +186,11 @@
<div class="service-set__subtitle">
<%= t("views.shared.service_comparison.tax_documents.subtitle") %>
</div>
<div class="service-set__subtitle">
<%= t("views.shared.service_comparison.tax_documents.subtitle") %>
</div>
<% if app_time.before?(Rails.configuration.state_file_end_of_in_progress_intakes) %>
<div class="service-set__subtitle">
<%= t("views.shared.service_comparison.tax_documents.subtitle") %>
</div>
<% end %>
</div>
<div class="service-set__services">
<div class="service full-service">
Expand All @@ -183,9 +199,11 @@
<div class="service diy">
<%= image_tag "icons/check-outline.svg", alt: t("general.affirmative"), class: "service-comparison--icon" %>
</div>
<div class="service direct-file">
<%= image_tag "icons/check-outline.svg", alt: t("general.affirmative"), class: "service-comparison--icon" %>
</div>
<% if app_time.before?(Rails.configuration.state_file_end_of_in_progress_intakes) %>
<div class="service direct-file">
<%= image_tag "icons/check-outline.svg", alt: t("general.affirmative"), class: "service-comparison--icon" %>
</div>
<% end %>
</div>
</div>
<div class="service-set service-set--hr">
Expand All @@ -201,9 +219,11 @@
<div class="service diy">
<%= t("views.shared.service_comparison.tax_payer_residency.diy") %>
</div>
<div class="service direct-file">
<%= t("views.shared.service_comparison.tax_payer_residency.direct_file") %>
</div>
<% if app_time.before?(Rails.configuration.state_file_end_of_in_progress_intakes) %>
<div class="service direct-file">
<%= t("views.shared.service_comparison.tax_payer_residency.direct_file") %>
</div>
<% end %>
</div>
</div>
<div class="service-set">
Expand All @@ -217,8 +237,10 @@
</div>
<div class="service diy">
</div>
<div class="service direct-file">
</div>
<% if app_time.before?(Rails.configuration.state_file_end_of_in_progress_intakes) %>
<div class="service direct-file">
</div>
<% end %>
</div>
</div>
<div class="service-set">
Expand All @@ -233,9 +255,11 @@
</div>
<div class="service diy">
</div>
<div class="service direct-file">
<%= image_tag "icons/check-outline.svg", alt: t("general.affirmative"), class: "service-comparison--icon" %>
</div>
<% if app_time.before?(Rails.configuration.state_file_end_of_in_progress_intakes) %>
<div class="service direct-file">
<%= image_tag "icons/check-outline.svg", alt: t("general.affirmative"), class: "service-comparison--icon" %>
</div>
<% end %>
</div>
</div>
<div class="service-set">
Expand All @@ -250,9 +274,11 @@
</div>
<div class="service diy">
</div>
<div class="service direct-file">
<%= image_tag "icons/check-outline.svg", alt: t("general.affirmative"), class: "service-comparison--icon" %>
</div>
<% if app_time.before?(Rails.configuration.state_file_end_of_in_progress_intakes) %>
<div class="service direct-file">
<%= image_tag "icons/check-outline.svg", alt: t("general.affirmative"), class: "service-comparison--icon" %>
</div>
<% end %>
</div>
</div>
<div class="service-set">
Expand All @@ -267,8 +293,10 @@
</div>
<div class="service diy">
</div>
<div class="service direct-file">
</div>
<% if app_time.before?(Rails.configuration.state_file_end_of_in_progress_intakes) %>
<div class="service direct-file">
</div>
<% end %>
</div>
</div>
<div class="service-set">
Expand All @@ -283,8 +311,10 @@
</div>
<div class="service diy">
</div>
<div class="service direct-file">
</div>
<% if app_time.before?(Rails.configuration.state_file_end_of_in_progress_intakes) %>
<div class="service direct-file">
</div>
<% end %>
</div>
</div>
<div class="service-set">
Expand Down
15 changes: 14 additions & 1 deletion spec/controllers/public_pages_controller_spec.rb
View file
Open in desktop
Expand Up @@ -58,7 +58,7 @@
end
end

context "when the app is not open for intake" do
context "when the app is not open for gyr intake" do
before do
allow(subject).to receive(:open_for_gyr_intake?).and_return(false)
end
Expand All @@ -70,6 +70,19 @@
expect(response.body).not_to include question_path(:id => Navigation::GyrQuestionNavigation.first)
end
end

context "when the app is not open for state file intakes" do
let(:past) { 1.day.ago }
before do
allow(Rails.application.config).to receive(:state_file_end_of_in_progress_intakes).and_return(past)
end

it "hides link to direct file" do
get :home

expect(response.body).not_to include I18n.t('views.shared.service_comparison.services.direct_file.cta')
end
end
end

context "in demo env" do
Expand Down