Prevent accepted resubmit #187434120 #4504
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tofarr
commented
Apr 17, 2024
tofarr
commented
- Do not resubmit if there is already an accepted return with the same SSN.
- Added a feature flag so we can turn this off if it is interfering with testing
|
Heroku app: https://gyr-review-app-4504-b29341d4c2fa.herokuapp.com/ |
rickreyhsig
reviewed
Apr 17, 2024
| end | ||
|
|
||
| context "when there is already a non-accepted submission in a different account with the same SSN" do | ||
| #let!(:efile_submission) { create :efile_submission, :accepted, :for_state, data_source: intake } |
There was a problem hiding this comment.
Can we nuke this comment?
rickreyhsig
approved these changes
Apr 17, 2024
jnf
reviewed
Apr 17, 2024
| @@ -17,6 +17,13 @@ def save | |||
| efile_info = StateFileEfileDeviceInfo.find_by(event_type: "submission", intake: @intake) | |||
| efile_info&.update!(attributes_for(:state_file_efile_device_info)) | |||
|
|
|||
| unless Flipper.enabled?(:allow_duplicate_submissions) | |||
| if accepted_submissions_with_same_ssn(@intake).any? | |||
| Rails.logger.warn "#{@intake.state_code}#{@intake.id} was not submitted because there is already an accepted submission for that ssn" | |||
There was a problem hiding this comment.
is this sufficient notification? would it be worth elevating this to a slack message or sentry warning or similar?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.