Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor withdrawal date things and pull state time #4503

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

embarnard
Copy link
Contributor

@embarnard embarnard commented Apr 16, 2024

  • Link to pivotal/JIRA issue: https://www.pivotaltracker.com/story/show/187437667
  • What was done?
    1. If a client is filing on April 15th or after we take the current time of their app instead of asking for a withdrawal date, so for NY it would be the current EST time and in AZ it would be the current MST time
    2. We remove the electronic-withdrawal-date box if April 15th or later
    3. Add a session toggle time for the deadline in respective timezones
    4. only perform certain validations before and after tax deadline date
  • How to test?
    • Added various form spec tests and tests on the application controller for the additional config times/methods
    • Specify any relevant testing environments used (e.g., development, staging, demo, Heroku).
      Can test on any environment, create an app (if NY can choose the javier test case to get the taxes owed page) check the functionality of the page before and after tax deadline using the session_toggles
  • Risk Assessment
    - Low risk, we shouldn't have any new submissions this season and if they were to run into a transmission error we should be able to resubmit easily

Copy link

Heroku app: https://gyr-review-app-4503-ed51f8e4b5e1.herokuapp.com/
View logs: heroku logs --app gyr-review-app-4503 (optionally add --tail)

@embarnard embarnard marked this pull request as ready for review April 24, 2024 15:33
@embarnard embarnard changed the title WIP: refactor withdrawal date things and pull state time Refactor withdrawal date things and pull state time Apr 24, 2024
Copy link
Contributor

@tofarr tofarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants