Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clearing bank details #187442420 #4502

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

tofarr
Copy link
Contributor

@tofarr tofarr commented Apr 16, 2024

  • Isolates the before_save action for clearing bank details from the other before_saves
  • Moves the before_save action into the base class to dry it up
  • Fixes logic hole where bank details are not cleared if the payment_or_deposit_type has not changed (This will still not incur extra load unless there were actual bank details present - changing a nil to a nil as part of a save is a noop)
  • Adds specs to cover this use case

Copy link

Heroku app: https://gyr-review-app-4502-98f4513c2263.herokuapp.com/
View logs: heroku logs --app gyr-review-app-4502 (optionally add --tail)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant