Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace the error icon #187092299 #4493

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Replace the error icon #187092299 #4493

wants to merge 9 commits into from

Conversation

tofarr
Copy link
Contributor

@tofarr tofarr commented Apr 15, 2024 •
edited

Error Page for statefile:
image

Error page for GYR is unchanged:
image

@github-actions GitHub Actions
Copy link

Heroku app: https://gyr-review-app-4493-70c026fb0bbe.herokuapp.com/
View logs: heroku logs --app gyr-review-app-4493 (optionally add --tail)

jnf
jnf reviewed May 10, 2024
View reviewed changes
Copy link
Contributor

@jnf jnf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's hold off on adding any conditional switching between gyr/fyst until we have a picture of if/how/when we're separating the products.

jnf
jnf requested changes May 10, 2024
View reviewed changes
Copy link
Contributor

@jnf jnf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hold for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnf jnf jnf requested changes

@tahsinaislam tahsinaislam tahsinaislam approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tofarr @jnf @tahsinaislam