Skip to content

Commit

Permalink
NullPointerException: Cannot invoke "String.equals(Object)" because the
Browse files Browse the repository at this point in the history 
[#182026669]

Removed unnecessary code from FilenameGenerator.java and
FilenameGeneratorTest.java

Co-authored-by: Chibuisi Enyia <cenyia@codeforamerica.org>
Co-authored-by: Eric M Johnson <eric.m.johnson@state.mn.us>
  • Loading branch information
@Rameshshakya @enyia21 @EricMN35Johnson
3 people committed May 17, 2022
1 parent cbbd882 commit f750fb1
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 90 deletions.
8 changes: 1 addition & 7 deletions src/main/java/org/codeforamerica/shiba/output/caf/FilenameGenerator.java
View file
Expand Up @@ -49,13 +49,7 @@ public String generatePdfFilename(Application application, Document document,
String prefix = getSharedApplicationPrefix(application, document, dhsProviderId);
String programs = getProgramCodes(application);
String pdfType = document.toString();
String eligible = "";
if(document.equals(CAF)) {
if (application.getApplicationData().getExpeditedEligibility().stream()
.filter(eligibility -> eligibility.toString().contains("ELIGIBLE")).findAny().isPresent())
eligible = "_EXPEDITED";
}
return "%s%s_%s%s.pdf".formatted(prefix, programs, pdfType, eligible);
return "%s%s_%s.pdf".formatted(prefix, programs, pdfType);
}

public String generateUploadedDocumentName(Application application, int index, String extension) {
Expand Down
85 changes: 2 additions & 83 deletions ...st/java/org/codeforamerica/shiba/output/documentfieldpreparers/FilenameGeneratorTest.java
View file
Expand Up @@ -5,12 +5,7 @@
import static org.codeforamerica.shiba.County.Hennepin;
import static org.codeforamerica.shiba.County.Olmsted;
import static org.codeforamerica.shiba.TribalNationRoutingDestination.RED_LAKE_NATION;
import static org.codeforamerica.shiba.output.caf.SnapExpeditedEligibility.ELIGIBLE;
import static org.codeforamerica.shiba.output.caf.SnapExpeditedEligibility.NOT_ELIGIBLE;
import static org.mockito.ArgumentMatchers.any;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.when;
import java.math.BigDecimal;

import java.time.Instant;
import java.time.ZoneOffset;
import java.time.ZonedDateTime;
Expand All @@ -20,28 +15,18 @@
import java.util.Map;
import org.codeforamerica.shiba.County;
import org.codeforamerica.shiba.CountyMap;
import org.codeforamerica.shiba.Money;
import org.codeforamerica.shiba.TribalNationRoutingDestination;
import org.codeforamerica.shiba.application.Application;
import org.codeforamerica.shiba.application.parsers.GrossMonthlyIncomeParser;
import org.codeforamerica.shiba.mnit.CountyRoutingDestination;
import org.codeforamerica.shiba.mnit.RoutingDestination;
import org.codeforamerica.shiba.mnit.TribalNationConfiguration;
import org.codeforamerica.shiba.output.Document;
import org.codeforamerica.shiba.output.caf.Eligibility;
import org.codeforamerica.shiba.output.caf.EligibilityListBuilder;
import org.codeforamerica.shiba.output.caf.ExpeditedEligibility;
import org.codeforamerica.shiba.output.caf.FilenameGenerator;
import org.codeforamerica.shiba.output.caf.SnapExpeditedEligibilityDecider;
import org.codeforamerica.shiba.output.caf.TotalIncomeCalculator;
import org.codeforamerica.shiba.output.caf.UnearnedIncomeCalculator;
import org.codeforamerica.shiba.output.caf.UtilityDeductionCalculator;
import org.codeforamerica.shiba.pages.data.ApplicationData;
import org.codeforamerica.shiba.testutilities.TestApplicationDataBuilder;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Nested;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.params.ParameterizedTest;
import org.springframework.http.MediaType;
import org.springframework.mock.web.MockMultipartFile;

Expand All @@ -52,18 +37,7 @@ class FilenameGeneratorTest {
private Application.ApplicationBuilder defaultApplicationBuilder;
private Map<String, TribalNationRoutingDestination> tribalNations;
private CountyRoutingDestination defaultCountyRoutingDestination;

UtilityDeductionCalculator mockUtilityDeductionCalculator = mock(
UtilityDeductionCalculator.class);
GrossMonthlyIncomeParser grossMonthlyIncomeParser = mock(GrossMonthlyIncomeParser.class);
TotalIncomeCalculator totalIncomeCalculator = mock(TotalIncomeCalculator.class);
UnearnedIncomeCalculator unearnedIncomeCalculator = mock(UnearnedIncomeCalculator.class);

SnapExpeditedEligibilityDecider decider = new SnapExpeditedEligibilityDecider(
mockUtilityDeductionCalculator, totalIncomeCalculator, grossMonthlyIncomeParser,
unearnedIncomeCalculator
);


@BeforeEach
void setUp() {
countyMap = new CountyMap<>();
Expand Down Expand Up @@ -323,59 +297,4 @@ void shouldBeDocInsteadOfMnbIfCountyIsHennepin() {
assertThat(notHennepinFileName).doesNotContain("olmstedNPI_DOC");
assertThat(notHennepinFileName).contains("olmstedNPI_MNB");
}

@Test
void shouldAppendExpeditedFileNameCorrectlyForCAFPdf() {
TestApplicationDataBuilder applicationDataBuilder = new TestApplicationDataBuilder()
.withApplicantPrograms(List.of("SNAP"))
.withPageData("thirtyDayIncome", "moneyMadeLast30Days", List.of("1"))
.withPageData("liquidAssets", "liquidAssets", List.of("2"))
.withPageData("migrantFarmWorker", "migrantOrSeasonalFarmWorker", List.of("false"))
.withPageData("homeExpensesAmount", "homeExpensesAmount", List.of("3"))
.withPageData("utilityPayments", "payForUtilities", List.of("utility"))
.withPageData("unearnedIncome", "unearnedIncome", List.of("SOCIAL_SECURITY"))
.withPageData("unearnedIncomeSources", "socialSecurityAmount", List.of())
.withPageData("unearnedIncomeCcap", "unearnedIncome", List.of("BENEFITS"))
.withPageData("unearnedIncomeSourcesCcap", "benefitsAmount", List.of())
.withPageData("preparingMealsTogether", "isPreparingMealsTogether", List.of("true"));
//.build();
when(mockUtilityDeductionCalculator.calculate(any())).thenReturn(Money.ZERO);
when(grossMonthlyIncomeParser.parse(applicationDataBuilder.build())).thenReturn(emptyList());
when(totalIncomeCalculator.calculate(any())).thenReturn(Money.parse("5000"));
when(unearnedIncomeCalculator.unearnedAmount(any())).thenReturn(BigDecimal.ZERO);

ApplicationData applicationData = applicationDataBuilder
.build();
String countyNPI = "someNPI";
County county = Hennepin;
countyMap.getCounties()
.put(county, CountyRoutingDestination.builder().dhsProviderId(countyNPI).build());

String applicationId = "someId";
List<Eligibility> expeditedEligibilityList = new ArrayList<>();
expeditedEligibilityList.add(decider.decide(applicationData));
EligibilityListBuilder listBuilder = new EligibilityListBuilder();
List<ExpeditedEligibility> list = listBuilder.buildEligibilityList(expeditedEligibilityList);
applicationData.setExpeditedEligibility(list);
Application application = defaultApplicationBuilder
.id(applicationId)
.county(county)
.completedAt(
ZonedDateTime.ofInstant(Instant.parse("2007-09-10T04:59:59.00Z"), ZoneOffset.UTC))
.applicationData(applicationData)
.build();

assertThat(decider.decide(applicationData)).isEqualTo(NOT_ELIGIBLE);
String fileName = filenameGenerator.generatePdfFilename(application, Document.CAF);

assertThat(fileName).isEqualTo(String.format("%s_MNB_%s_%s_%s_%s_%s%s.pdf",
countyNPI, "20070909", "235959", applicationId, "F", "CAF", ""));
//TODO @ParameterizedTest to check for all possible decider output like ELIGIBLE, NOT_ELIGIBLE and UNDERTERMINED
/* when(totalIncomeCalculator.calculate(any())).thenReturn(Money.ONE);
assertThat(decider.decide(applicationData)).isEqualTo(ELIGIBLE);
fileName = filenameGenerator.generatePdfFilename(application, Document.CAF);
assertThat(fileName).isEqualTo(String.format("%s_MNB_%s_%s_%s_%s_%s%s.pdf",
countyNPI, "20070909", "235959", applicationId, "F", "CAF", "_EXPEDITED"));*/
}
}

0 comments on commit f750fb1

Please sign in to comment.