Fixes #573 - Browser upgrade alert #588
Conversation
Fixes #573 - Displays dismissible upgrade alert for visitors that visit with IE8. URL given in alert is https://browser-update.org/update.html. Sets a cookie after alert is closed so alert isn’t displayed again the same day. Cookie expires after 1 day. - Implements addEventListener on alert component so observers can respond to closing of the alert box.
anselmbradford
force-pushed
the
573-browser-upgrade-alert
branch
from
2ced596
to
23def4b
Compare
|
@monfresh ready for review. Looks like:
Can be tested in Sauce Labs under "New Interactive Session" with IE8 in WinXP or Win7. Load page, see alert; reload page, see alert; close alert, reload page, don't see alert. |
|
I don't think this should be turned on by default. It should probably be controlled via a config var, and the text, link text, and URL should all be customizable. This is not a critical feature, so I wouldn't spend time on it right now. Let's focus on our issues cleanup exercise first. |
|
👍 Sounds good. Also, a dev note... this'll just display for IE8 and below, but an alternative approach (the Modernizr approach) is to show it based on browser capabilities. So if there were a set of core features we wanted to say the browser had to support to be "modern," it wouldn't be much of a change to make the notice display when those features weren't present. |
|
Closing this since no one is visiting the site with IE, according to SMC-Connect's analytics. |
with IE8. URL given in alert is https://browser-update.org/update.html.
Sets a cookie after alert is closed so alert isn’t displayed again the
same day. Cookie expires after 1 day.
respond to closing of the alert box.