Provide upgrade message for IE8 users #573
Labels
Comments
|
I also asked about this on the #general Slack channel and got some interesting responses. Here are some resources: |
anselmbradford
added a commit
that referenced
this issue
Sep 8, 2014
- Removes unused util/util methods. - Moves cookie code to its own CRUD module. - Fixes #565 - Removes server-side handling of Google Translate cookie and consolidates cookie handling in google-translate-manager. - Moves isTranslated method to google-translate-manager. - Updates “close” button method to “clear” to go with new naming. - Pads header popup title text so (x) button doesn’t risk overlapping. - Gives alert close button min height/width so that size doesn’t change as (x) icon is loading. - Implements addEventListener on alert so events can be attached to it being dismissed. - Fixes #573 - Creates IE8-specific override stylesheet and pulls :before and :after selectors out of main stylesheet into this one. Also provides overrides to elements that have box-shadows but no border by providing a border instead (alert and popup). - Updates modernizr custom build to include html5-shiv and include all core features used on the site. - Removes gsub from requirejs include tag.
anselmbradford
added a commit
that referenced
this issue
Sep 8, 2014
- Removes unused util/util methods. - Moves cookie code to its own CRUD module. - Fixes #565 - Removes server-side handling of Google Translate cookie and consolidates cookie handling in google-translate-manager. - Moves isTranslated method to google-translate-manager. - Updates “close” button method to “clear” to go with new naming. - Pads header popup title text so (x) button doesn’t risk overlapping. - Gives alert close button min height/width so that size doesn’t change as (x) icon is loading. - Implements addEventListener on alert so events can be attached to it being dismissed. - Fixes #573 - Creates IE8-specific override stylesheet and pulls :before and :after selectors out of main stylesheet into this one. Also provides overrides to elements that have box-shadows but no border by providing a border instead (alert and popup). - Updates modernizr custom build to include html5-shiv and include all core features used on the site. - Removes gsub from requirejs include tag.
anselmbradford
added a commit
that referenced
this issue
Sep 9, 2014
Fixes #573 - Displays dismissible upgrade alert for visitors that visit with IE8. URL given in alert is https://browser-update.org/update.html. Sets a cookie after alert is closed so alert isn’t displayed again the same day. Cookie expires after 1 day. - Implements addEventListener on alert component so observers can respond to closing of the alert box.
anselmbradford
added a commit
that referenced
this issue
Sep 9, 2014
Fixes #573 - Displays dismissible upgrade alert for visitors that visit with IE8. URL given in alert is https://browser-update.org/update.html. Sets a cookie after alert is closed so alert isn’t displayed again the same day. Cookie expires after 1 day. - Implements addEventListener on alert component so observers can respond to closing of the alert box.
|
Another example of this codeforamerica/bizfriendly-web#190 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Per discussion on Slack #ohana channel, something like https://browser-update.org/# or http://nmsdvid.com/iealert/
...Or display an alert with a message and link to upgrade using a call to the
app/alert-managerinside the ie8 conditional JS code that runs when a visitor is using IE8.The text was updated successfully, but these errors were encountered: