Adjust code to start to use required fields logic that ffb added. #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bseeger
commented
May 10, 2024
| aria-describedby=${hasHelpText ? inputName + '-help-text' : ''}, | ||
| aria-labelledby=${hasAriaLabel ? ariaLabel : ''}, | ||
| aria-invalid=${hasError}" | ||
| th:value="${hasValue ? value : fieldData.getOrDefault(inputName, '')}"> |
There was a problem hiding this comment.
This spot allows for an override of the data filled into the field. I don't think we need this in MD's code. But maybe we should pull this logic into the ffb?
bseeger
force-pushed
the
changes_for_required_fields
branch
from
1220fd7
to
08a53cd
Compare
bseeger
commented
May 23, 2024
| @@ -640,10 +640,10 @@ income-delete-confirmation.title=Delete household member income | |||
| income-delete-confirmation.yes=Yes, delete it | |||
| household-income-total.add-by-job=Do you want to add your monthly household income by job instead? This can give your caseworker more details to better help with your application. | |||
| household-income-total.no=No, continue | |||
| household-income-total.yes=Yes, add income by job | |||
| household-income-total.yes=Yes, add income by job3 x | |||
There was a problem hiding this comment.
I'll take this out.
bseeger
commented
May 23, 2024
| <th:block | ||
| th:replace="~{fragments/form :: form(action=${formAction}, content=~{::formContent})}"> | ||
| <th:block th:ref="formContent"> | ||
| <div class="form-card__content"> | ||
| <th:block | ||
| th:replace="~{fragments/inputs/money :: money(inputName='householdIncomeLast30Days', ariaLabel='header', placeholder='0.00')}"/> | ||
| th:replace="'fragments/inputs/money' :: money(inputName='householdIncomeLast30Days', ariaLabel='header header-help-message', placeholder='0.00')"/> | ||
| </div> |
There was a problem hiding this comment.
Hmmm... not sure if my rebase reversed this, but we do want the ~{fragement} syntax instead of the single quotes.
There was a problem hiding this comment.
nm, I'm taking this out as it's a duplicate field on this page now.
bseeger
commented
May 23, 2024
src/main/resources/templates/mdBenefitsFlow/expeditedSnapMoneyOnHandAmount.html
Outdated
Show resolved
Hide resolved
bseeger
commented
May 23, 2024
|
For some reason this is not showing as required. (householdMoneyOnHandAmount.html page) |
bseeger
commented
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps address: https://www.pivotaltracker.com/story/show/186994206
text.htmltemplate from this code base and lets us default to the one in ffl (and therefore get required field functionality)selectHelpNeeded.htmlto move some text into the card header.