Add retry count mechanism and virus scan check to google drive transmission #205
Conversation
bseeger
force-pushed
the
bseeger/google_drive_retry_and_virus_187339289
branch
from
bbaf55f
to
32bfc76
Compare
build.gradle
Outdated
| } else { | ||
| implementation "org.codeforamerica.platform:form-flow:${formFlowLibraryVersion}" | ||
| println "📚Using form flow library ${formFlowLibraryVersion}" | ||
| } |
There was a problem hiding this comment.
I think this change is temporary and I will reverse this once the FFL changes have been released.
| if (!status.equals(TransmissionStatus.TRANSMITTING)) { | ||
| int retryCount = transmission.getRetryCount(); | ||
| retryCount++; | ||
| transmission.setRetryCount(retryCount); |
There was a problem hiding this comment.
Question: if the retry count is == to the max, should we set status differently, or keep it as QUEUED? It will not get picked up again, but maybe the status should reflect this as well?
There was a problem hiding this comment.
How should we notify ourselves if an transmission fails to send after 5 tries? We should put in some code here that causes us to be alerted. Maybe an ERROR with a specific message and then a Datadog monitor for that message??? @stabai @spokenbird @analoo?
There was a problem hiding this comment.
It's easiest if there's a logging level that always triggers an alert. Do we have something like CRITICAL that I can set up to do that?
There was a problem hiding this comment.
Hmmm... no CRITICAL that I can see.
bseeger
force-pushed
the
bseeger/google_drive_retry_and_virus_187339289
branch
2 times, most recently
from
0fdb164
to
65a6ff5
Compare
bseeger
force-pushed
the
bseeger/google_drive_retry_and_virus_187339289
branch
from
139d785
to
4e6e82b
Compare
Addresses: https://www.pivotaltracker.com/story/show/187339289 and https://www.pivotaltracker.com/story/show/187212763
Relies on this change getting into form flow library: codeforamerica/form-flow#542