Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically indicate required input fields #502

Merged
merged 41 commits into from May 9, 2024
Merged

Automatically indicate required input fields #502

merged 41 commits into from May 9, 2024

Commits on May 6, 2024

  1. Automatically indicate required text fields

    @spokenbird
    spokenbird committed May 6, 2024
    Configuration menu
    Copy the full SHA
    cc095d4 View commit details
    Browse the repository at this point in the history

  2. Adds error handling changes for the date input

    @spokenbird
    spokenbird committed May 6, 2024
    Configuration menu
    Copy the full SHA
    56392be View commit details
    Browse the repository at this point in the history

  3. Update money input to show required attribute

    @spokenbird
    spokenbird committed May 6, 2024
    Configuration menu
    Copy the full SHA
    d5140ac View commit details
    Browse the repository at this point in the history

  4. Update number, phone and ssn inputs to show required attribute

    @spokenbird
    spokenbird committed May 6, 2024
    Configuration menu
    Copy the full SHA
    7759557 View commit details
    Browse the repository at this point in the history

  5. Update select input to show required attribute

    @spokenbird
    spokenbird committed May 6, 2024
    Configuration menu
    Copy the full SHA
    7f14ae9 View commit details
    Browse the repository at this point in the history

  6. Update radio input to show required attribute in fieldset

    @spokenbird
    spokenbird committed May 6, 2024
    Configuration menu
    Copy the full SHA
    be34480 View commit details
    Browse the repository at this point in the history

  7. Only render error element if errors are present and add appropriate m… 

    …argin
    @spokenbird
    spokenbird committed May 6, 2024
    Configuration menu
    Copy the full SHA
    086265f View commit details
    Browse the repository at this point in the history

  8. Indidcate required attribute on fieldset not individual input

    @spokenbird
    spokenbird committed May 6, 2024
    Configuration menu
    Copy the full SHA
    1662c15 View commit details
    Browse the repository at this point in the history

  9. Add tests

    @spokenbird
    spokenbird committed May 6, 2024
    Configuration menu
    Copy the full SHA
    61987fc View commit details
    Browse the repository at this point in the history

  10. Do not show required asterisk if single input screen

    @spokenbird
    spokenbird committed May 6, 2024
    Configuration menu
    Copy the full SHA
    31d7717 View commit details
    Browse the repository at this point in the history

  11. Fix broken check on date errors in test

    @spokenbird
    spokenbird committed May 6, 2024
    Configuration menu
    Copy the full SHA
    d07c290 View commit details
    Browse the repository at this point in the history

  12. Initialize required inputs list once in ValidationService

    @spokenbird
    spokenbird committed May 6, 2024
    Configuration menu
    Copy the full SHA
    ccdcd2e View commit details
    Browse the repository at this point in the history

  13. Use map for instant lookup of required inputs

    @spokenbird
    spokenbird committed May 6, 2024
    Configuration menu
    Copy the full SHA
    a812a87 View commit details
    Browse the repository at this point in the history

  14. Add required input check for screenWithOneInput

    @spokenbird
    spokenbird committed May 6, 2024
    Configuration menu
    Copy the full SHA
    93e301c View commit details
    Browse the repository at this point in the history

  15. Add documentation for screen with one input

    @spokenbird
    spokenbird committed May 6, 2024
    Configuration menu
    Copy the full SHA
    775133f View commit details
    Browse the repository at this point in the history

  16. Fix path

    @sree-cfa @spokenbird
    sree-cfa authored and spokenbird committed May 6, 2024
    Configuration menu
    Copy the full SHA
    7c6e739 View commit details
    Browse the repository at this point in the history

  17. Update required fields to use message properties and (required) language

    @spokenbird
    spokenbird committed May 6, 2024
    Configuration menu
    Copy the full SHA
    db296c3 View commit details
    Browse the repository at this point in the history

  18. Add optional required field to all input types

    @spokenbird
    spokenbird committed May 6, 2024
    Configuration menu
    Copy the full SHA
    2d5eb2c View commit details
    Browse the repository at this point in the history

  19. Add required indication to screen with one input pattern

    @spokenbird
    spokenbird committed May 6, 2024
    Configuration menu
    Copy the full SHA
    815b6d3 View commit details
    Browse the repository at this point in the history

  20. Update README

    @spokenbird
    spokenbird committed May 6, 2024
    Configuration menu
    Copy the full SHA
    4c2f714 View commit details
    Browse the repository at this point in the history

  21. Fix failing tests

    @spokenbird
    spokenbird committed May 6, 2024
    Configuration menu
    Copy the full SHA
    10e397a View commit details
    Browse the repository at this point in the history

  22. Fix failing tests

    @spokenbird
    spokenbird committed May 6, 2024
    Configuration menu
    Copy the full SHA
    f9c3b4e View commit details
    Browse the repository at this point in the history

  23. Fix failing tests and remove aria-required attribute

    @spokenbird
    spokenbird committed May 6, 2024
    Configuration menu
    Copy the full SHA
    1104f60 View commit details
    Browse the repository at this point in the history

  24. Hopefully fix tests failing in CI

    @spokenbird
    spokenbird committed May 6, 2024
    Configuration menu
    Copy the full SHA
    82d14ad View commit details
    Browse the repository at this point in the history

  25. Hopefully fix tests failing in CI Part 2

    @spokenbird
    spokenbird committed May 6, 2024
    Configuration menu
    Copy the full SHA
    c3f8800 View commit details
    Browse the repository at this point in the history

  26. Hopefully fix tests failing in CI Part 3

    @spokenbird
    spokenbird committed May 6, 2024
    Configuration menu
    Copy the full SHA
    e6ba57e View commit details
    Browse the repository at this point in the history

  27. Hopefully fix tests failing in CI Part 4

    @spokenbird
    spokenbird committed May 6, 2024
    Configuration menu
    Copy the full SHA
    a78249f View commit details
    Browse the repository at this point in the history

  28. Hopefully fix tests failing in CI Part 5

    @spokenbird
    spokenbird committed May 6, 2024
    Configuration menu
    Copy the full SHA
    872648b View commit details
    Browse the repository at this point in the history

  29. Hopefully fix tests failing in CI Part 6

    @spokenbird
    spokenbird committed May 6, 2024
    Configuration menu
    Copy the full SHA
    788d454 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Convert failing test to use Selenium instead

    @spokenbird
    spokenbird committed May 7, 2024
    Configuration menu
    Copy the full SHA
    c627343 View commit details
    Browse the repository at this point in the history

  2. Fix screenWithOneInput.html

    @spokenbird
    spokenbird committed May 7, 2024
    Configuration menu
    Copy the full SHA
    467b397 View commit details
    Browse the repository at this point in the history

  3. PR Review changes

    @spokenbird
    spokenbird committed May 7, 2024
    Configuration menu
    Copy the full SHA
    04a22d6 View commit details
    Browse the repository at this point in the history

  4. Await client to see if it fixes CI

    @spokenbird
    spokenbird committed May 7, 2024
    Configuration menu
    Copy the full SHA
    8076382 View commit details
    Browse the repository at this point in the history

  5. Try a different CI Fix

    @spokenbird
    spokenbird committed May 7, 2024
    Configuration menu
    Copy the full SHA
    cf17a28 View commit details
    Browse the repository at this point in the history

  6. Try yet anothing thing

    @spokenbird
    spokenbird committed May 7, 2024
    Configuration menu
    Copy the full SHA
    be1ed9e View commit details
    Browse the repository at this point in the history

  7. Try specifying test profile

    @spokenbird
    spokenbird committed May 7, 2024
    Configuration menu
    Copy the full SHA
    c9373f4 View commit details
    Browse the repository at this point in the history

  8. Try specifying test profile 2

    @spokenbird
    spokenbird committed May 7, 2024
    Configuration menu
    Copy the full SHA
    8ffc1fe View commit details
    Browse the repository at this point in the history

  9. Dont test -- will do in starter-app instead

    @spokenbird
    spokenbird committed May 7, 2024
    Configuration menu
    Copy the full SHA
    06d6626 View commit details
    Browse the repository at this point in the history

  10. Account for multiple flows when generating required inputs map

    @spokenbird
    spokenbird committed May 7, 2024
    Configuration menu
    Copy the full SHA
    4682c5a View commit details
    Browse the repository at this point in the history

  11. Fix null issue

    @spokenbird
    spokenbird committed May 7, 2024
    Configuration menu
    Copy the full SHA
    b5805b8 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. Changes from PR review

    @spokenbird
    spokenbird committed May 9, 2024
    Configuration menu
    Copy the full SHA
    1146b5a View commit details
    Browse the repository at this point in the history