-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): Bump hono from 3.11.3 to 3.11.7 #29
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes in this commit are primarily updates to the 'hono' package versions in both the package.json and pnpm-lock.yaml files. No obvious issues are evident from this diff. However, it is key to ensure that these version updates do not introduce breaking changes. Dependency updates should also be followed by full regression testing to identify potential issues. Additionally, confirm whether the integrity SHA in the lock file was updated correctly after the package update.
@@ -5,7 +5,7 @@ | |||
}, | |||
"dependencies": { | |||
"@hono/node-server": "^1.3.1", | |||
"hono": "^3.11.2", | |||
"hono": "^3.11.7", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 'hono' package has been updated, ensure all necessary testing is done to confirm that this update doesn't introduce any breaking changes.
specifier: ^3.11.2 | ||
version: 3.11.3 | ||
specifier: ^3.11.7 | ||
version: 3.11.7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version update should be accompanied by any necessary changes to your code that depend on this package. Make sure to verify this.
@@ -4463,8 +4463,8 @@ packages: | |||
resolution: {integrity: sha512-EWGTfnTqAO2L/j5HZgoM/3z82L7necsJ0pO9Tp0X1wil3PDLrkypTBRgVO2ExehEEvUycejZD3FuRaXpZZc3kw==} | |||
dev: true | |||
|
|||
/hono@3.11.3: | |||
resolution: {integrity: sha512-MWYBcIS4dZJo9e/852Zwl+gqBiUSRknMOZ/MbW7kW8JiWixTJ58pzXVIeBq7jnvFq3AZ9uQ35QyVpzV05sdNFw==} | |||
/hono@3.11.7: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be the updated integrity SHA for the 'hono' package. It's important to confirm if this SHA the correct one corresponding to the new version of the package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The update seems to be mainly about increasing the version of the 'hono' dependency from 3.11.2 to 3.11.7 in both 'package.json' and 'pnpm-lock.yaml' files. The integrity hashes also have been updated correctly with the new version. Overall, these changes don't introduce any obvious issues.
@@ -5,7 +5,7 @@ | |||
}, | |||
"dependencies": { | |||
"@hono/node-server": "^1.3.1", | |||
"hono": "^3.11.2", | |||
"hono": "^3.11.7", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 'hono' package has been upgraded. We should ensure this new version has been sufficiently tested and does not introduce breaking changes in our application.
@@ -241,8 +241,8 @@ importers: | |||
specifier: ^1.3.1 | |||
version: 1.3.1 | |||
hono: | |||
specifier: ^3.11.2 | |||
version: 3.11.3 | |||
specifier: ^3.11.7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correctly updated the version of 'hono' in the pnpm-lock file as well. This ensures version consistency across different parts of our codebase.
@@ -4463,8 +4463,8 @@ packages: | |||
resolution: {integrity: sha512-EWGTfnTqAO2L/j5HZgoM/3z82L7necsJ0pO9Tp0X1wil3PDLrkypTBRgVO2ExehEEvUycejZD3FuRaXpZZc3kw==} | |||
dev: true | |||
|
|||
/hono@3.11.3: | |||
resolution: {integrity: sha512-MWYBcIS4dZJo9e/852Zwl+gqBiUSRknMOZ/MbW7kW8JiWixTJ58pzXVIeBq7jnvFq3AZ9uQ35QyVpzV05sdNFw==} | |||
/hono@3.11.7: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The updated integrity hash is for the correct version and implies that the downloaded package has not been tampered with. This is essential for securing the codebase.
3b85153
to
e5d08e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodecovAI submitted a new review for e5d08e2
@@ -4807,8 +4807,8 @@ packages: | |||
resolution: {integrity: sha512-EWGTfnTqAO2L/j5HZgoM/3z82L7necsJ0pO9Tp0X1wil3PDLrkypTBRgVO2ExehEEvUycejZD3FuRaXpZZc3kw==} | |||
dev: true | |||
|
|||
/hono@3.11.3: | |||
resolution: {integrity: sha512-MWYBcIS4dZJo9e/852Zwl+gqBiUSRknMOZ/MbW7kW8JiWixTJ58pzXVIeBq7jnvFq3AZ9uQ35QyVpzV05sdNFw==} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The integrity of the new version of 'hono' is updated as well. Let's check if it corresponds to the correct hash of the new hono package (v3.11.7) to verify the package integrity.
1b87255
to
67f4c88
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodecovAI submitted a new review for 67f4c88
specifier: ^3.11.2 | ||
version: 3.11.3 | ||
specifier: ^3.11.7 | ||
version: 3.11.7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'hono' version is now aligned with the package.json file. Good that consistency has been maintained between these files.
67f4c88
to
236df8b
Compare
236df8b
to
211670a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodecovAI submitted a new review for 211670a
/hono@3.11.3: | ||
resolution: {integrity: sha512-MWYBcIS4dZJo9e/852Zwl+gqBiUSRknMOZ/MbW7kW8JiWixTJ58pzXVIeBq7jnvFq3AZ9uQ35QyVpzV05sdNFw==} | ||
/hono@3.11.7: | ||
resolution: {integrity: sha512-TcfAq7IdipF+9coxnuzYlSSBXbm9mTyWjjagLCv/2ampboNcKJdi+XCK5G48mHQtpI5+9Rj3J4FfcGgw9vzIww==} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The node engine version specified here seems to be kept same as >=16.0.0
. It is important to ensure that the updated hono
package is fully compatible with this Node.js version.
172face
to
939c8a1
Compare
Bumps [hono](https://github.com/honojs/hono) from 3.11.3 to 3.11.7. - [Release notes](https://github.com/honojs/hono/releases) - [Commits](honojs/hono@v3.11.3...v3.11.7) --- updated-dependencies: - dependency-name: hono dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
939c8a1
to
deaab92
Compare
Bumps hono from 3.11.3 to 3.11.7.
Release notes
Sourced from hono's releases.
... (truncated)
Commits
8edb160
v3.11.78e2b6b0
Merge pull request from GHSA-f6gv-hh8j-q8vqaf9e485
chore: bump up@hono/eslint-config
(#1816)18b6282
chore: use@hono/eslint-config
(#1815)0e11444
v3.11.64c4c4ee
fix(context): setstatus
correctly (#1814)a86b75b
v3.11.5af8d16b
fix(context):c.json()
allows object and returns JSONParsed<T> (#1806)87e256b
docs(readme): updatehono/tiny
size (#1809)0f33cf8
fix(context): set headers values correctly (#1808)You can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.