Fixed map sometimes not loading bug #7446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabriellui1
force-pushed
the
gabriel/map-not-loading-issue
branch
from
3c8679b
to
872f712
Compare
|
Not sure why commits from other branches were on this PR but this should be fixed now. |
smallst
requested changes
May 16, 2024
app/views/play/CampaignView.js
Outdated
| if (levelPositions[idx]) { | ||
| this.courseLevelsFake[idx].position = levelPositions[idx] | ||
| } | ||
| return this.listenToOnce(this.campaign, 'sync', () => { |
There was a problem hiding this comment.
i don't think this could work. since courseLevels and campaign load is sync and we're not sure which is sync first. (actually I doubt campaign would be fast) so I think you need some thing like
listenToOnce(courseLevels, () => courseLevelsLoaded = true; checking())
listenToOnce(campaign, () => campaignLoaded = true; checking())
and in checking function,
only when courseLevelsLoaded and campaignLoaded both true, run following logics, reasonable?
adamkecskes
approved these changes
May 29, 2024
There was a problem hiding this comment.
LGTM! Thank you @gabriellui1 for fixing this! Just tested and works perfectly!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes ENG-517
