Fix comment whitespace issues in translate-utils.coffee #7057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sweep-ai[bot]](https://avatars.githubusercontent.com/in/307814?s=60&v=4){kind=small}
wwzeng1
reviewed
Jul 25, 2023
app/lib/translate-utils.coffee
Outdated
| finals.splice(insertPlace, 0, finals.splice(i,1)[0]) | ||
|
|
||
| return strs.concat([finals.slice(0, insertPlace).join('\n'), finals.slice(insertPlace).join('\n')]) | ||
| matchBrackets = (str, startIndex) -> |
wwzeng1
reviewed
Jul 25, 2023
app/lib/translate-utils.coffee
Outdated
|
|
||
| if language is 'lua' | ||
| # Try incrementing all literal array indexes under, say, 10 by 1 to offset 1-based indexing. Hack, but most of those levels will need manual attention anyway. | ||
| # Try incrementing all literal array indexes under, say, 10 by 1 to offset 1-based indexing. Hack, but most of those levels will need manual attention anyway. | ||
| s = s.replace /\[(\d)\]/g, (match, index) -> "[#{parseInt(index, 10) + 1}]" | ||
|
|
||
| # TODO: see if we can do something about lack of a continue statement in Lua? Maybe too hard and we should give up. | ||
|
|
||
| lines = s.split '\n' | ||
| output = (lines.map (line) -> line.slice 1).join('\n') # Remove leading convenience whitespace that we added | ||
| output |
sweep-ai
bot
changed the title
|
GitHub actions yielded the following error. The command that failed is There are a lot of errors. This is likely a larger issue with the PR and not a small linting/type-checking issue. This is likely a linting or type-checking issue with the source code but if you are updating the GitHub Actions or versioning, this could be an issue with the GitHub Action yaml files. |
|
GitHub actions yielded the following error. The relevant lines from the logs corresponding to the error are: The command that failed is There are a lot of errors. This is likely a larger issue with the PR and not a small linting/type-checking issue. This is likely a linting or type-checking issue with the source code but if you are updating the GitHub Actions or versioning, this could be an issue with the GitHub Action yaml files. |
|
GitHub actions yielded the following error. The command that failed is There are a lot of errors. This is likely a larger issue with the PR and not a small linting/type-checking issue. This is likely a linting or type-checking issue with the source code but if you are updating the GitHub Actions or versioning, this could be an issue with the GitHub Action yaml files. |
|
GitHub actions yielded the following error. The command that failed is Please note that the error message suggests running an install with npm@5 or later to generate a package-lock.json file before running There are a lot of errors. This is likely a larger issue with the PR and not a small linting/type-checking issue. This is likely a linting or type-checking issue with the source code but if you are updating the GitHub Actions or versioning, this could be an issue with the GitHub Action yaml files. |
|
GitHub actions yielded the following error. The command that failed is Please note that the error message suggests running an install with npm@5 or later to generate a package-lock.json file before running There are a lot of errors. This is likely a larger issue with the PR and not a small linting/type-checking issue. This is likely a linting or type-checking issue with the source code but if you are updating the GitHub Actions or versioning, this could be an issue with the GitHub Action yaml files. |
|
GitHub actions yielded the following error. The command that failed is There are a lot of errors. This is likely a larger issue with the PR and not a small linting/type-checking issue. This is likely a linting or type-checking issue with the source code but if you are updating the GitHub Actions or versioning, this could be an issue with the GitHub Action yaml files. |
|
GitHub actions yielded the following error. The command that failed is Please note that the error message suggests running an install with npm@5 or later to generate a package-lock.json file before retrying the There are a lot of errors. This is likely a larger issue with the PR and not a small linting/type-checking issue. This is likely a linting or type-checking issue with the source code but if you are updating the GitHub Actions or versioning, this could be an issue with the GitHub Action yaml files. |
|
GitHub actions yielded the following error. The command that failed is Please note that the error message states that There are a lot of errors. This is likely a larger issue with the PR and not a small linting/type-checking issue. This is likely a linting or type-checking issue with the source code but if you are updating the GitHub Actions or versioning, this could be an issue with the GitHub Action yaml files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the comment whitespace issues in the
translate-utils.coffeefile. Some of the comments were not indented correctly and were starting at the beginning of the line. This PR adjusts the indentation of the comments to align with the code they are associated with.Changes Made
translate-utils.coffeefile to align with the code they are commenting on.Testing
No functional changes were made, so no additional testing is required.
Related Issue
Fixes #[issue_number]
Fixes #7024.
To checkout this PR branch, run the following command in your terminal: