codecentric/spring-boot-admin#2528 InstanceFilter added #2875
Conversation
There was a problem hiding this comment.
Hi @dzahbarov,
first of all, thanks for your contribution!
There is one comment in code, please have a look. The rest looks good!
Additionally, can you please also add a short paragraph to the documentation? I guess the best place would be below "Customize". Therefore create a small file similar to customize_interceptors.adoc and reference it in site.xml.
Thank you
| /** | ||
| * @author dzahbarov | ||
| */ | ||
| public class InstanceFilter { |
There was a problem hiding this comment.
As this is explicitly meant to be an extension point it would be nice to have at least one sentence of javadoc telling what you can do and what are the consequences.
We also discussed if it would be useful to separate this into an interface that explicitly describes the extension point and a default implementation class "IncludeAllInstancesFilter" or something similar. Not sure if this would be better, what do you think?
Added the ability to filter instances from the instanceRepository.