feat(keycloakx): Support optimized start #762
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mruzicka
force-pushed
the
optimized-start-support
branch
from
c11ffce
to
0e541f5
Compare
mruzicka
changed the title
Signed-off-by: Michal Růžička <michal.ruza@gmail.com>
mruzicka
force-pushed
the
optimized-start-support
branch
from
0e541f5
to
7f8e36b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the chart aware of the so called optimized start of Keycloak. This optimized start is achieved by passing the
--optimizedargument to the Keycloak'sstartcommand:When Keycloak is started this way it assumes it had already been optimized (see Creating an optimized Keycloak build) and ignores options which only take effect during the optimization process but does log a warning when it encounters them. The warning may look something like this:
The intent of this PR is to get rid of this warning by not passing the build/optimization-time only options when an optimized start is used. For that purpose a boolean value
optimizedis introduced which is used to guard the rendering of the build-time only options.Note that the
kc.cache*options are in fact run-time options (even though mentioned in the example warning above). This is a bug in the definition of these options in Keycloak. It's already been fixed in keycloak/keycloak@a3669a6, so once this is released, Keycloak will stop complaining about those.